From: Thomas Huth <thuth@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: lvivier@redhat.com, ehabkost@redhat.com, mst@redhat.com,
libvir-list@redhat.com, cohuck@redhat.com, david@redhat.com,
dgilbert@redhat.com, armbru@redhat.com, pasic@linux.ibm.com,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [PATCH] cphp: remove deprecated cpu-add command(s)
Date: Fri, 11 Sep 2020 14:43:34 +0200 [thread overview]
Message-ID: <5b5c027e-8f9f-8949-b8c2-7b1a05d98a1e@redhat.com> (raw)
In-Reply-To: <20200911123329.938221-1-imammedo@redhat.com>
What does cphp in the subject mean?
On 11/09/2020 14.33, Igor Mammedov wrote:
> theses were deprecatedince since 4.0, remove both HMP and QMP variants.
deprecated since
> Users should use device_add commnad instead. To get list of
command
> possible CPUs and options, use 'info hotpluggable-cpus' HMP
> or query-hotpluggable-cpus QMP command.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> include/hw/boards.h | 1 -
> include/hw/i386/pc.h | 1 -
> include/monitor/hmp.h | 1 -
> docs/system/deprecated.rst | 25 +++++----
> hmp-commands.hx | 15 ------
> hw/core/machine-hmp-cmds.c | 12 -----
> hw/core/machine-qmp-cmds.c | 12 -----
> hw/i386/pc.c | 27 ----------
> hw/i386/pc_piix.c | 1 -
> hw/s390x/s390-virtio-ccw.c | 12 -----
> qapi/machine.json | 24 ---------
> tests/qtest/cpu-plug-test.c | 100 ++++--------------------------------
> tests/qtest/test-hmp.c | 1 -
> 13 files changed, 21 insertions(+), 211 deletions(-)
With the typos fixed:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-09-11 12:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 12:33 [PATCH] cphp: remove deprecated cpu-add command(s) Igor Mammedov
2020-09-11 12:43 ` Thomas Huth [this message]
2020-09-11 14:48 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b5c027e-8f9f-8949-b8c2-7b1a05d98a1e@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=libvir-list@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).