From: Richard Henderson <richard.henderson@linaro.org>
To: Frank Chang <frank.chang@sifive.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
Bin Meng <bin.meng@windriver.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Vincent Chen <vincent.chen@sifive.com>,
Alistair Francis <alistair.francis@wdc.com>,
Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH RESEND v2] target/riscv: Set mstatus_hs.[SD|FS] bits if Clean and V=1 in mark_fs_dirty()
Date: Sun, 19 Sep 2021 09:32:15 -0700 [thread overview]
Message-ID: <5b642e26-aff5-912e-721b-1d808f0f6eea@linaro.org> (raw)
In-Reply-To: <CAE_xrPh+CzNK-nnsO6NSk+FKowXW2Tbva9abhpgAD13xfPak4A@mail.gmail.com>
On 9/18/21 7:54 PM, Frank Chang wrote:
> Do you mean it's better to change to code sequence to something like:
>
> static void mark_fs_dirty(DisasContext *ctx)
> {
> .....
>
> if (ctx->virt_enabled && ctx->mstatus_hs_fs != MSTATUS_FS) {
> /* Remember the stage change for the rest of the TB. */
> ctx->mstatus_hs_fs = MSTATUS_FS;
> .....
> }
>
> if (ctx->mstatus_fs != MSTATUS_FS) {
> /* Remember the state change for the rest of the TB. */
> ctx->mstatus_fs = MSTATUS_FS;
> .....
> }
> }
>
> If so, I can update and send out the v3 patch.
Yes, something like that.
r~
prev parent reply other threads:[~2021-09-19 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 9:31 [PATCH RESEND v2] target/riscv: Set mstatus_hs.[SD|FS] bits if Clean and V=1 in mark_fs_dirty() frank.chang
2021-09-18 18:46 ` Richard Henderson
2021-09-19 2:54 ` Frank Chang
2021-09-19 16:32 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b642e26-aff5-912e-721b-1d808f0f6eea@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=frank.chang@sifive.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=vincent.chen@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).