From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DA34C48BC3 for ; Tue, 20 Feb 2024 16:48:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcTH6-0007mV-Rc; Tue, 20 Feb 2024 11:47:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcTH4-0007m4-3Y for qemu-devel@nongnu.org; Tue, 20 Feb 2024 11:47:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcTH2-00044U-1i for qemu-devel@nongnu.org; Tue, 20 Feb 2024 11:47:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708447634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lqUxo03A0QGr5YhjQ0UZLJ10kh/EHHkhJt9b0NN1thw=; b=A/YBf5AajV43hQk9amOBC8kJRe52zxz7rm3uCDyJOagX7qwPxaGjPMGVO0LpzZ7Og5zUpN DNZ43Odvexnj+sD7TD+HrshAYAi8a6LAax3ZUw/ZE+z0UykdIjqDXyBV29MtxGh6p0K+6Q F6o4CToNLJHKDswNDVzkStsldK+3Q38= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-D51k0Q3SMDi0sVHll5apgQ-1; Tue, 20 Feb 2024 11:47:12 -0500 X-MC-Unique: D51k0Q3SMDi0sVHll5apgQ-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7830ab8fb5aso492559385a.2 for ; Tue, 20 Feb 2024 08:47:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708447632; x=1709052432; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lqUxo03A0QGr5YhjQ0UZLJ10kh/EHHkhJt9b0NN1thw=; b=CS0P6rFEsoEjJ15PspCytpkSjhFe/2+wNu+V4tN7arASgefF99qHYympYA4A8kc3eh 2vn9TwfZKgpIcwzie2X0h2GzQcEloXE++I57ZrozthV0EaCcqoYWULwXfpO49OaTZovJ 2ON8OWx1kUf874K0c9tLnxJHktUHOlQ6Qq+1Y7uHDq/xjcr/DIx3yUqxG92ICEc14HyC sOZxLE3mI65pGGF2X1KZk2+wdzDQ5lPNlG98eud07ISOKur0BcF1ziJCWJSne7ErRqc9 P7bPaeePq32366OaGFYVdKiM5wZbghnNETN85HmsbO/lW1MdMrECk8UjMgQLOyXVdIHL VE/A== X-Gm-Message-State: AOJu0Yyz5gV3euoQUtWsAb3oPgsJrFcYQKwriWt0x4JdOEyZtWETsjLn eRcbUdmSMQGhOaFkqipf0XtwaXykCIUKlCbRuvkZ4t2NHJOk/Z4hsXamMd9lcoVRcenU6yuR+m3 HVdSggKH3wBPfjHj40pkUvm9+LWCkmhuZjxOeNfcKApeOhMxn9YVl X-Received: by 2002:a05:620a:225:b0:787:4173:a7ea with SMTP id u5-20020a05620a022500b007874173a7eamr13073540qkm.70.1708447632006; Tue, 20 Feb 2024 08:47:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGeMS7I2bBMylebjKjandgm1gg/Iovsrbw04sRMnyp8K4dZRySSvu1iYZlHQppgAh0g+SdV2w== X-Received: by 2002:a05:620a:225:b0:787:4173:a7ea with SMTP id u5-20020a05620a022500b007874173a7eamr13073526qkm.70.1708447631737; Tue, 20 Feb 2024 08:47:11 -0800 (PST) Received: from [192.168.0.9] (ip-109-43-178-100.web.vodafone.de. [109.43.178.100]) by smtp.gmail.com with ESMTPSA id d11-20020a05620a240b00b00787797f8f2asm574575qkn.74.2024.02.20.08.47.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Feb 2024 08:47:11 -0800 (PST) Message-ID: <5b6950e7-1b32-43b1-aff7-08f54b52a056@redhat.com> Date: Tue, 20 Feb 2024 17:47:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] hw/loongarch: Set minimium memory size as 256M Content-Language: en-US To: Bibo Mao , Song Gao , Peter Xu , Fabiano Rosas , Laurent Vivier Cc: qemu-devel@nongnu.org References: <20240220124126.1164081-1-maobibo@loongson.cn> <20240220124126.1164081-5-maobibo@loongson.cn> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240220124126.1164081-5-maobibo@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.05, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 20/02/2024 13.41, Bibo Mao wrote: > The minium memory size for LoongArch UEFI bios is 256M, also some > test cases such as migration and qos uses parameter 256M. > > Here set minium memory size for Loongarch VirtMachine with 256M, > also default memory size is changed with 256M. > > Signed-off-by: Bibo Mao > --- > hw/loongarch/virt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c > index a7d700497d..5bc332f4e3 100644 > --- a/hw/loongarch/virt.c > +++ b/hw/loongarch/virt.c > @@ -815,8 +815,8 @@ static void virt_init(MachineState *machine) > cpu_model = LOONGARCH_CPU_TYPE_NAME("la464"); > } > > - if (ram_size < 1 * GiB) { > - error_report("ram_size must be greater than 1G."); > + if (ram_size < 256 * MiB) { > + error_report("ram_size must be greater than 256M."); > exit(1); > } > create_fdt(vms); > @@ -1144,7 +1144,7 @@ static void virt_class_init(ObjectClass *oc, void *data) > HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(oc); > > mc->init = virt_init; > - mc->default_ram_size = 1 * GiB; > + mc->default_ram_size = 256 * MiB; While changing the minimum ram_size in the first hunk is certainly a good idea, you should maybe consider twice whether you also want to change the default_ram_size here. 256 MiB is often not enough to run a guest OS like Linux, so for most users it might be more convenient if you have a default_ram_size of 1GiB instead. At least that's what I've seen on other architectures. YMMV. Thomas