From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
peter.maydell@linaro.org, "John Snow" <jsnow@redhat.com>
Cc: Fam Zheng <fam@euphon.net>, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 2/9] tests/docker: fix DOCKER_PARTIAL_IMAGES
Date: Tue, 17 Sep 2019 21:44:17 +0200 [thread overview]
Message-ID: <5b77d03b-753b-5ea6-af17-bfccac2614d5@redhat.com> (raw)
In-Reply-To: <20190917184109.12564-3-alex.bennee@linaro.org>
On 9/17/19 8:41 PM, Alex Bennée wrote:
> Finger trouble in a previous clean-up inadvertently set
> DEBIAN_PARTIAL_IMAGES instead of DOCKER_PARTIAL_IMAGES.
Arf :)
> Fixes: 44d5a8bf5d2
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/docker/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 50a400b573a..0d033bfbea8 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -7,7 +7,7 @@ DOCKER_FILES_DIR := $(SRC_PATH)/tests/docker/dockerfiles
> DOCKER_DEPRECATED_IMAGES := debian
> # we don't run tests on intermediate images (used as base by another image)
> DOCKER_PARTIAL_IMAGES := debian debian8 debian9 debian10 debian-sid
> -DEBIAN_PARTIAL_IMAGES += debian8-mxe debian-9-mxe debian-ports debian-bootstrap
> +DOCKER_PARTIAL_IMAGES += debian8-mxe debian-9-mxe debian-ports debian-bootstrap
As John noticed, we have another typo: "debian-9-mxe" -> "debian9-mxe"
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> DOCKER_IMAGES := $(filter-out $(DOCKER_DEPRECATED_IMAGES),$(sort $(notdir $(basename $(wildcard $(DOCKER_FILES_DIR)/*.docker)))))
> DOCKER_TARGETS := $(patsubst %,docker-image-%,$(DOCKER_IMAGES))
> # Use a global constant ccache directory to speed up repetitive builds
>
next prev parent reply other threads:[~2019-09-17 19:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 18:41 [Qemu-devel] [PATCH v1 0/9] testing/next (docker,podman,float) Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 1/9] tests/docker: add sanitizers back to clang build Alex Bennée
2019-09-17 18:43 ` John Snow
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 2/9] tests/docker: fix DOCKER_PARTIAL_IMAGES Alex Bennée
2019-09-17 19:44 ` Philippe Mathieu-Daudé [this message]
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 3/9] podman: fix command invocation Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 4/9] target/ppc: fix signal delivery for ppc64abi32 Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 5/9] tests/tcg: clean-up some comments after the de-tangling Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 6/9] tests/tcg: re-enable linux-test for ppc64abi32 Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch Alex Bennée
2019-09-17 19:46 ` Richard Henderson
2019-09-17 21:00 ` Alex Bennée
2019-09-17 21:28 ` Richard Henderson
2019-09-18 11:33 ` Alex Bennée
2019-09-18 15:14 ` Richard Henderson
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 8/9] tests/tcg: add generic version of float_convs Alex Bennée
2019-09-17 19:49 ` Richard Henderson
2019-09-17 20:57 ` Alex Bennée
2019-09-17 21:31 ` Richard Henderson
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 9/9] tests/tcg: add refs for PPC float_[convs|madds] tests (FAILS TESTS) Alex Bennée
2019-09-18 8:02 ` [Qemu-devel] [PATCH v1 0/9] testing/next (docker, podman, float) no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b77d03b-753b-5ea6-af17-bfccac2614d5@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).