* [Qemu-devel] [PATCH] configure: Make -Waddress-of-packed-member warnings be errors
@ 2019-02-08 13:21 Peter Maydell
2019-02-08 13:33 ` Thomas Huth
2019-02-08 15:21 ` [Qemu-devel] " Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: Peter Maydell @ 2019-02-08 13:21 UTC (permalink / raw)
To: qemu-devel; +Cc: patches
We have now managed to eradicate all the places in the codebase
that triggered clang's -Waddress-of-packed-member warning. Remove
the compiler flag that exempted it from our usual -Werror policy.
This will prevent any new problematic code being added in future.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
configure | 1 -
1 file changed, 1 deletion(-)
diff --git a/configure b/configure
index fbd0825488c..50ac5d90f2e 100755
--- a/configure
+++ b/configure
@@ -1881,7 +1881,6 @@ gcc_flags="-Wno-missing-include-dirs -Wempty-body -Wnested-externs $gcc_flags"
gcc_flags="-Wendif-labels -Wno-shift-negative-value $gcc_flags"
gcc_flags="-Wno-initializer-overrides -Wexpansion-to-defined $gcc_flags"
gcc_flags="-Wno-string-plus-int $gcc_flags"
-gcc_flags="-Wno-error=address-of-packed-member $gcc_flags"
# Note that we do not add -Werror to gcc_flags here, because that would
# enable it for all configure tests. If a configure test failed due
# to -Werror this would just silently disable some features,
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Make -Waddress-of-packed-member warnings be errors
2019-02-08 13:21 [Qemu-devel] [PATCH] configure: Make -Waddress-of-packed-member warnings be errors Peter Maydell
@ 2019-02-08 13:33 ` Thomas Huth
2019-02-14 9:48 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-02-08 15:21 ` [Qemu-devel] " Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2019-02-08 13:33 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: patches, QEMU Trivial
On 2019-02-08 14:21, Peter Maydell wrote:
> We have now managed to eradicate all the places in the codebase
> that triggered clang's -Waddress-of-packed-member warning. Remove
> the compiler flag that exempted it from our usual -Werror policy.
> This will prevent any new problematic code being added in future.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> configure | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configure b/configure
> index fbd0825488c..50ac5d90f2e 100755
> --- a/configure
> +++ b/configure
> @@ -1881,7 +1881,6 @@ gcc_flags="-Wno-missing-include-dirs -Wempty-body -Wnested-externs $gcc_flags"
> gcc_flags="-Wendif-labels -Wno-shift-negative-value $gcc_flags"
> gcc_flags="-Wno-initializer-overrides -Wexpansion-to-defined $gcc_flags"
> gcc_flags="-Wno-string-plus-int $gcc_flags"
> -gcc_flags="-Wno-error=address-of-packed-member $gcc_flags"
> # Note that we do not add -Werror to gcc_flags here, because that would
> # enable it for all configure tests. If a configure test failed due
> # to -Werror this would just silently disable some features,
Great!
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Make -Waddress-of-packed-member warnings be errors
2019-02-08 13:33 ` Thomas Huth
@ 2019-02-14 9:48 ` Laurent Vivier
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2019-02-14 9:48 UTC (permalink / raw)
To: Thomas Huth, Peter Maydell, qemu-devel; +Cc: QEMU Trivial, patches
On 08/02/2019 14:33, Thomas Huth wrote:
> On 2019-02-08 14:21, Peter Maydell wrote:
>> We have now managed to eradicate all the places in the codebase
>> that triggered clang's -Waddress-of-packed-member warning. Remove
>> the compiler flag that exempted it from our usual -Werror policy.
>> This will prevent any new problematic code being added in future.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> configure | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index fbd0825488c..50ac5d90f2e 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1881,7 +1881,6 @@ gcc_flags="-Wno-missing-include-dirs -Wempty-body -Wnested-externs $gcc_flags"
>> gcc_flags="-Wendif-labels -Wno-shift-negative-value $gcc_flags"
>> gcc_flags="-Wno-initializer-overrides -Wexpansion-to-defined $gcc_flags"
>> gcc_flags="-Wno-string-plus-int $gcc_flags"
>> -gcc_flags="-Wno-error=address-of-packed-member $gcc_flags"
>> # Note that we do not add -Werror to gcc_flags here, because that would
>> # enable it for all configure tests. If a configure test failed due
>> # to -Werror this would just silently disable some features,
>
> Great!
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Make -Waddress-of-packed-member warnings be errors
2019-02-08 13:21 [Qemu-devel] [PATCH] configure: Make -Waddress-of-packed-member warnings be errors Peter Maydell
2019-02-08 13:33 ` Thomas Huth
@ 2019-02-08 15:21 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-08 15:21 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: patches
On 2/8/19 2:21 PM, Peter Maydell wrote:
> We have now managed to eradicate all the places in the codebase
> that triggered clang's -Waddress-of-packed-member warning. Remove
> the compiler flag that exempted it from our usual -Werror policy.
> This will prevent any new problematic code being added in future.
Yay!
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> configure | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configure b/configure
> index fbd0825488c..50ac5d90f2e 100755
> --- a/configure
> +++ b/configure
> @@ -1881,7 +1881,6 @@ gcc_flags="-Wno-missing-include-dirs -Wempty-body -Wnested-externs $gcc_flags"
> gcc_flags="-Wendif-labels -Wno-shift-negative-value $gcc_flags"
> gcc_flags="-Wno-initializer-overrides -Wexpansion-to-defined $gcc_flags"
> gcc_flags="-Wno-string-plus-int $gcc_flags"
> -gcc_flags="-Wno-error=address-of-packed-member $gcc_flags"
> # Note that we do not add -Werror to gcc_flags here, because that would
> # enable it for all configure tests. If a configure test failed due
> # to -Werror this would just silently disable some features,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-14 9:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-08 13:21 [Qemu-devel] [PATCH] configure: Make -Waddress-of-packed-member warnings be errors Peter Maydell
2019-02-08 13:33 ` Thomas Huth
2019-02-14 9:48 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-02-08 15:21 ` [Qemu-devel] " Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).