From: Richard Henderson <richard.henderson@linaro.org>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v1 5/7] s390x/tcg: Factor out gen_addi_and_wrap_i64() from get_address()
Date: Mon, 25 Feb 2019 07:53:41 -0800 [thread overview]
Message-ID: <5b958dce-1a57-7be6-f5fe-f24ca7cae7f2@linaro.org> (raw)
In-Reply-To: <20190225115552.7534-6-david@redhat.com>
On 2/25/19 3:55 AM, David Hildenbrand wrote:
> Also properly wrap in 24bit mode. While at it, convert the comment (and
> drop the comment about fundamental TCG optimizations).
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/translate.c | 41 +++++++++++++++++++++++++---------------
> 1 file changed, 26 insertions(+), 15 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> +static inline void gen_addi_and_wrap_i64(DisasContext *s, TCGv_i64 dst,
> + TCGv_i64 src, int64_t imm)
I would drop the inline and let the compiler choose.
I'm using very few explicit inline markers these days...
r~
next prev parent reply other threads:[~2019-02-25 15:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 11:55 [Qemu-devel] [PATCH v1 0/7] s390x/tcg: Cleanups and refactorings for Vector David Hildenbrand
2019-02-25 11:55 ` [Qemu-devel] [PATCH v1 1/7] s390x/tcg: RXE has an optional M3 field David Hildenbrand
2019-02-25 12:18 ` Thomas Huth
2019-02-25 15:46 ` Richard Henderson
2019-02-25 11:55 ` [Qemu-devel] [PATCH v1 2/7] s390x/tcg: Simplify disassembler operands initialization David Hildenbrand
2019-02-25 12:20 ` Thomas Huth
2019-02-25 12:21 ` Cornelia Huck
2019-02-25 13:32 ` David Hildenbrand
2019-02-25 15:47 ` Richard Henderson
2019-02-25 11:55 ` [Qemu-devel] [PATCH v1 3/7] s390x/tcg: Clarify terminology in vec_reg_offset() David Hildenbrand
2019-02-25 12:30 ` Thomas Huth
2019-02-25 13:33 ` David Hildenbrand
2019-02-25 15:47 ` Richard Henderson
2019-02-25 11:55 ` [Qemu-devel] [PATCH v1 4/7] s390x/tcg: Factor out vec_full_reg_offset() David Hildenbrand
2019-02-25 12:32 ` Thomas Huth
2019-02-25 11:55 ` [Qemu-devel] [PATCH v1 5/7] s390x/tcg: Factor out gen_addi_and_wrap_i64() from get_address() David Hildenbrand
2019-02-25 15:53 ` Richard Henderson [this message]
2019-02-25 16:08 ` David Hildenbrand
2019-02-25 11:55 ` [Qemu-devel] [PATCH v1 6/7] s390x/tcg: Implement LOAD LENGTHENED short HFP to long HFP David Hildenbrand
2019-02-25 15:59 ` Richard Henderson
2019-02-25 11:55 ` [Qemu-devel] [PATCH v1 7/7] s390x/tcg: Implement LOAD COUNT TO BLOCK BOUNDARY David Hildenbrand
2019-02-25 16:14 ` Richard Henderson
2019-02-25 16:17 ` David Hildenbrand
2019-02-25 16:40 ` Richard Henderson
2019-02-25 19:55 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b958dce-1a57-7be6-f5fe-f24ca7cae7f2@linaro.org \
--to=richard.henderson@linaro.org \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).