From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: sagark@eecs.berkeley.edu, palmer@sifive.com,
peer.adelt@hni.uni-paderborn.de, Alistair.Francis@wdc.com,
mjc@sifive.com
Subject: Re: [Qemu-devel] [PATCH 7/7] target/riscv: Splice decodetree inputs for riscv32 vs riscv64
Date: Wed, 24 Oct 2018 11:33:35 +0200 [thread overview]
Message-ID: <5bb7fe79-a2a0-7a01-beb8-c23c3a2d2d5f@mail.uni-paderborn.de> (raw)
In-Reply-To: <20181023120454.28553-8-richard.henderson@linaro.org>
On 10/23/18 2:04 PM, Richard Henderson wrote:
> This primarily solves the case for RVC that several insns are
> completely different, decode and all, between the two. But it
> also means that we need less ifdefing for RV{I,M,A,F,D}.
> ---
> target/riscv/insn_trans/trans_rva.inc.c | 46 +---------------
> target/riscv/insn_trans/trans_rvc.inc.c | 71 -------------------------
> target/riscv/insn_trans/trans_rvd.inc.c | 26 +--------
> target/riscv/insn_trans/trans_rvf.inc.c | 18 +------
> target/riscv/insn_trans/trans_rvi.inc.c | 49 +++--------------
> target/riscv/insn_trans/trans_rvm.inc.c | 22 +-------
> target/riscv/Makefile.objs | 23 ++++++--
> target/riscv/insn16-32.decode | 31 +++++++++++
> target/riscv/insn16-64.decode | 33 ++++++++++++
> target/riscv/insn16.decode | 24 +++------
> target/riscv/insn32.decode | 53 +-----------------
> target/riscv/insn64.decode | 71 +++++++++++++++++++++++++
> 12 files changed, 176 insertions(+), 291 deletions(-)
> create mode 100644 target/riscv/insn16-32.decode
> create mode 100644 target/riscv/insn16-64.decode
> create mode 100644 target/riscv/insn64.decode
>
Either this or one of the last two patches breaks booting fedora. I
couldn't figure the problem out just yet.
Cheers,
Bastian
next prev parent reply other threads:[~2018-10-24 9:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 12:04 [Qemu-devel] [PATCH 0/7] riscv decodetree followup Richard Henderson
2018-10-23 12:04 ` [Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets Richard Henderson
2018-10-23 12:56 ` Bastian Koppelmann
2018-10-23 13:27 ` Philippe Mathieu-Daudé
2018-10-23 13:54 ` Richard Henderson
2018-10-23 18:40 ` Philippe Mathieu-Daudé
2018-10-23 12:04 ` [Qemu-devel] [PATCH 2/7] decodetree: Remove "insn" argument from trans_* expanders Richard Henderson
2018-10-23 13:04 ` Bastian Koppelmann
2018-10-23 13:08 ` Richard Henderson
2018-10-23 13:25 ` Philippe Mathieu-Daudé
2018-10-23 13:25 ` Bastian Koppelmann
2018-10-23 13:56 ` Richard Henderson
2018-10-23 12:04 ` [Qemu-devel] [PATCH 3/7] target/riscv: Update for decodetree insn argument change Richard Henderson
2018-10-23 13:40 ` Bastian Koppelmann
2018-10-23 12:04 ` [Qemu-devel] [PATCH 4/7] target/riscv: Rename some argument sets in insn32.decode Richard Henderson
2018-10-23 12:21 ` Philippe Mathieu-Daudé
2018-10-23 13:03 ` Richard Henderson
2018-10-23 13:40 ` Bastian Koppelmann
2018-10-23 12:04 ` [Qemu-devel] [PATCH 5/7] target/riscv: Convert @cs_2 insns to share translation functions Richard Henderson
2018-10-23 12:26 ` Philippe Mathieu-Daudé
2018-10-23 13:04 ` Richard Henderson
2018-10-23 13:41 ` Bastian Koppelmann
2018-10-23 12:04 ` [Qemu-devel] [PATCH 6/7] target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns Richard Henderson
2018-10-23 12:27 ` Philippe Mathieu-Daudé
2018-10-23 12:04 ` [Qemu-devel] [PATCH 7/7] target/riscv: Splice decodetree inputs for riscv32 vs riscv64 Richard Henderson
2018-10-23 12:17 ` Philippe Mathieu-Daudé
2018-10-24 9:33 ` Bastian Koppelmann [this message]
2018-10-24 9:49 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bb7fe79-a2a0-7a01-beb8-c23c3a2d2d5f@mail.uni-paderborn.de \
--to=kbastian@mail.uni-paderborn.de \
--cc=Alistair.Francis@wdc.com \
--cc=mjc@sifive.com \
--cc=palmer@sifive.com \
--cc=peer.adelt@hni.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).