* [PATCH] ui/dbus: fix clang compilation issue
@ 2023-07-26 15:12 marcandre.lureau
2023-07-26 15:15 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: marcandre.lureau @ 2023-07-26 15:12 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth, philmd, Marc-André Lureau, Gerd Hoffmann
From: Marc-André Lureau <marcandre.lureau@redhat.com>
../ui/dbus-listener.c:236:9: error: expected expression
Error *err = NULL;
See:
https://gitlab.com/qemu-project/qemu/-/issues/1782#note_1488517427
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
ui/dbus-listener.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c
index 02fc6ae239..30917271ab 100644
--- a/ui/dbus-listener.c
+++ b/ui/dbus-listener.c
@@ -232,7 +232,7 @@ static void dbus_call_update_gl(DisplayChangeListener *dcl,
egl_fb_read_rect(ddl->ds, &ddl->fb, x, y, w, h);
dbus_gfx_update(dcl, x, y, w, h);
break;
- case SHARE_KIND_D3DTEX:
+ case SHARE_KIND_D3DTEX: {
Error *err = NULL;
assert(ddl->d3d_texture);
@@ -249,6 +249,7 @@ static void dbus_call_update_gl(DisplayChangeListener *dcl,
dbus_update_gl_cb,
g_object_ref(ddl));
break;
+ }
default:
g_warn_if_reached();
}
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ui/dbus: fix clang compilation issue
2023-07-26 15:12 [PATCH] ui/dbus: fix clang compilation issue marcandre.lureau
@ 2023-07-26 15:15 ` Thomas Huth
2023-07-31 9:24 ` Philippe Mathieu-Daudé
2023-08-01 21:44 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2023-07-26 15:15 UTC (permalink / raw)
To: marcandre.lureau, qemu-devel; +Cc: philmd, Gerd Hoffmann, QEMU Trivial
On 26/07/2023 17.12, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> ../ui/dbus-listener.c:236:9: error: expected expression
> Error *err = NULL;
>
> See:
> https://gitlab.com/qemu-project/qemu/-/issues/1782#note_1488517427
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/dbus-listener.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c
> index 02fc6ae239..30917271ab 100644
> --- a/ui/dbus-listener.c
> +++ b/ui/dbus-listener.c
> @@ -232,7 +232,7 @@ static void dbus_call_update_gl(DisplayChangeListener *dcl,
> egl_fb_read_rect(ddl->ds, &ddl->fb, x, y, w, h);
> dbus_gfx_update(dcl, x, y, w, h);
> break;
> - case SHARE_KIND_D3DTEX:
> + case SHARE_KIND_D3DTEX: {
> Error *err = NULL;
> assert(ddl->d3d_texture);
>
> @@ -249,6 +249,7 @@ static void dbus_call_update_gl(DisplayChangeListener *dcl,
> dbus_update_gl_cb,
> g_object_ref(ddl));
> break;
> + }
> default:
> g_warn_if_reached();
> }
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ui/dbus: fix clang compilation issue
2023-07-26 15:12 [PATCH] ui/dbus: fix clang compilation issue marcandre.lureau
2023-07-26 15:15 ` Thomas Huth
@ 2023-07-31 9:24 ` Philippe Mathieu-Daudé
2023-08-01 21:44 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-07-31 9:24 UTC (permalink / raw)
To: marcandre.lureau, qemu-devel; +Cc: thuth, Gerd Hoffmann
On 26/7/23 17:12, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> ../ui/dbus-listener.c:236:9: error: expected expression
> Error *err = NULL;
>
> See:
> https://gitlab.com/qemu-project/qemu/-/issues/1782#note_1488517427
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/dbus-listener.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ui/dbus: fix clang compilation issue
2023-07-26 15:12 [PATCH] ui/dbus: fix clang compilation issue marcandre.lureau
2023-07-26 15:15 ` Thomas Huth
2023-07-31 9:24 ` Philippe Mathieu-Daudé
@ 2023-08-01 21:44 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-08-01 21:44 UTC (permalink / raw)
To: marcandre.lureau, qemu-devel; +Cc: thuth, Gerd Hoffmann
On 26/7/23 17:12, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> ../ui/dbus-listener.c:236:9: error: expected expression
> Error *err = NULL;
>
> See:
> https://gitlab.com/qemu-project/qemu/-/issues/1782#note_1488517427
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/dbus-listener.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, queued via misc-fixes.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-01 21:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-26 15:12 [PATCH] ui/dbus: fix clang compilation issue marcandre.lureau
2023-07-26 15:15 ` Thomas Huth
2023-07-31 9:24 ` Philippe Mathieu-Daudé
2023-08-01 21:44 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).