qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
To: Eric Blake <eblake@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH 1/1] docs: fix mistake in dirty bitmap feature description
Date: Wed, 3 Feb 2021 13:29:03 +0300	[thread overview]
Message-ID: <5bc4c2ef-e1dd-f0bc-12f1-62c1a11a9fe4@openvz.org> (raw)
In-Reply-To: <cbfdf78b-57ff-3482-3adc-f2eb3e65237e@redhat.com>

On 2/3/21 2:08 AM, Eric Blake wrote:
> On 2/2/21 4:50 PM, Denis V. Lunev wrote:
>> On 2/3/21 1:15 AM, Eric Blake wrote:
>>> On 1/28/21 11:21 AM, Vladimir Sementsov-Ogievskiy wrote:
>>>> 28.01.2021 20:13, Denis V. Lunev wrote:
>>>>> Original specification says that l1 table size if 64 * l1_size, which
>>>>> is obviously wrong. The size of the l1 entry is 64 _bits_, not bytes.
>>>>> Thus 64 is to be replaces with 8 as specification says about bytes.
>>>>>
>>>>> There is also minor tweak, field name is renamed from l1 to l1_table,
>>>>> which matches with the later text.
>>>>>
>>>>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>>>>> CC: Stefan Hajnoczi <stefanha@redhat.com>
>>>>> CC: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>>> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>>>
>>> I saw the subject "dirty bitmap", and assumed it would go through my
>>> dirty bitmap tree.  In reality, it's unrelated to the dirty bitmap code.
>>>  Would an improved subject line help?
>> hmm. Actually this is about "how the dirty bitmaps are stored in the
>> Parallels Image format". The section is called "dirty bitmap feature".
>>
>> What I can propose? :)
>>
>> "docs: fix mistake in Parallels Image "dirty bitmap" feature description"
>>
>> Will this work for you?
> That feels a bit long; maybe just:
>
> docs: fix Parallels Image "dirty bitmap" section
>
>

looks great to me. Should I resend?

Den


  reply	other threads:[~2021-02-03 10:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 17:13 [PATCH 1/1] docs: fix mistake in dirty bitmap feature description Denis V. Lunev
2021-01-28 17:21 ` Vladimir Sementsov-Ogievskiy
2021-02-02 22:15   ` Eric Blake
2021-02-02 22:50     ` Denis V. Lunev
2021-02-02 23:08       ` Eric Blake
2021-02-03 10:29         ` Denis V. Lunev [this message]
2021-02-03 16:50           ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bc4c2ef-e1dd-f0bc-12f1-62c1a11a9fe4@openvz.org \
    --to=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).