From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 512FEC433B4 for ; Mon, 12 Apr 2021 02:13:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA39760249 for ; Mon, 12 Apr 2021 02:13:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA39760249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVm4a-00083P-Tx for qemu-devel@archiver.kernel.org; Sun, 11 Apr 2021 22:13:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVm3i-0007RT-Pb for qemu-devel@nongnu.org; Sun, 11 Apr 2021 22:12:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:58397) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVm3g-0003tN-Pv for qemu-devel@nongnu.org; Sun, 11 Apr 2021 22:12:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618193531; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b3VdiBlwFBNTfs65yJhoM4BSBwKRbU/s/QhJhSQWuoA=; b=Axlp9v3DbqggeARfvegER5XNSP+E+ibV/kUGtqkEkeDp1uoskAPWSUHFQF8lAxdF/SvJSV /I+Vyuh5F91BGKoCHGzkoisH5eXIXfDX78gBTxLQixZj91qdq7ltT5gt1/ld34Cpt1Tnci 2AvNgIkl1tBHHngn4wV9AUaSCikmcUI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-516-FMMoYOUfPZewXTM6NRvhLQ-1; Sun, 11 Apr 2021 22:12:09 -0400 X-MC-Unique: FMMoYOUfPZewXTM6NRvhLQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 938255B364; Mon, 12 Apr 2021 02:12:08 +0000 (UTC) Received: from [10.64.54.68] (vpn2-54-68.bne.redhat.com [10.64.54.68]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AD5635C3E4; Mon, 12 Apr 2021 02:12:05 +0000 (UTC) Subject: Re: [PATCH 2/2] target/arm: Initlaize PMU feature for scratch vcpu To: Peter Maydell References: <20210407040100.9933-1-gshan@redhat.com> <20210407040100.9933-2-gshan@redhat.com> From: Gavin Shan Message-ID: <5bc4cb38-6af4-e6e6-c2bf-d89463b28540@redhat.com> Date: Mon, 12 Apr 2021 14:11:53 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=gshan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=gshan@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Gavin Shan Cc: Richard Henderson , QEMU Developers , Marcin Juszkiewicz , qemu-arm , Shan Gavin , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Peter, On 4/7/21 5:38 PM, Peter Maydell wrote: > On Wed, 7 Apr 2021 at 03:01, Gavin Shan wrote: >> >> If the scratch vCPU is initialized without PMU feature, we receive >> error on reading PMCR_EL0 as it's invisible in this case. It leads >> to host probing failure. >> >> This fixes the issue by initializing the scratch vcpu with the PMU >> feature enabled and reading PMCR_EL0 from host. Otherwise, its value >> is set according to the detected target. >> >> Fixes: f7fb73b8cdd3 ("target/arm: Make number of counters in PMCR follow the CPU") > > This commit has been reverted... > > I couldn't find a cover letter for these patches, so it's > hard to tell what you're aiming to do with them. Could you > make sure you always send a cover letter with a multiple-patch > series, please ? This also helps with our automated tooling. > Sorry for the delay. Yep, I will always include cover letter for a series. For this particular series, it's invalid since f7fb73b8cdd3 has been reverted. So please ignore this series. Thanks, Gavin