From: "Michael Fritscher" <michael@fritscher.net>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Michael Fritscher <michael@fritscher.net>,
gkurz@linux.vnet.ibm.com, sw@weilnetz.de,
aneesh.kumar@linux.vnet.ibm.com, mst@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 15/18] Fix unavailable fields in stbuf under Windows.
Date: Mon, 6 Nov 2017 16:23:37 +0100 [thread overview]
Message-ID: <5bc62a3a54dd9c1eb19c41bc5f710e3e.squirrel@mifritscher.de> (raw)
In-Reply-To: <d86b8115-9512-d487-a508-906c5f259764@redhat.com>
Hi,
> Likewise, I think it should be struct FileOperations's lstat member that
> uses struct V9fsStatDotl instead of struct stat. Then
> stat_to_v9stat_dotl would be hidden inside 9p-local.c (and 9p-local.c
> isn't going to be used by Windows at all, so this patch disappears).
>
> Paolo
>
At first: thanks for reviewing!
Yes, the main question for me at this stage is:
* use the 9p-local.c and try workaround the limitations (e.g. lack of
the *at functions) by creating stubs)
* make a own 9p-local-windows.c and use ntdlls functions, which is a bit
more ugly.
I decribed these options a moment ago in the other mail in more detail.
For me both way are fine.
Best regards,
Michael Fritscher
next prev parent reply other threads:[~2017-11-06 15:23 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 11:13 [Qemu-devel] Make 9pfs buildable for Windows Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 01/18] Add definitions needed by file-op-9p.h " Michael Fritscher
2017-11-06 13:34 ` Greg Kurz
2017-09-29 11:13 ` [Qemu-devel] [PATCH 02/18] #include <sys/vfs.h> is not available under Windows Michael Fritscher
2017-11-06 14:27 ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 03/18] Disable the proxy fsdev " Michael Fritscher
2017-11-06 13:44 ` Greg Kurz
2017-11-06 15:17 ` Michael Fritscher
2017-11-06 16:51 ` Greg Kurz
2017-09-29 11:13 ` [Qemu-devel] [PATCH 04/18] Don't include sys/resource.h on Windows Michael Fritscher
2017-11-06 14:27 ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 05/18] Add definitions for 9p.c Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 06/18] Stub out functions for 9pfs Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 07/18] Fix unused variable error and unsuded function if FS_IOC_GETVERSION is not defined Michael Fritscher
2017-11-06 14:29 ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 08/18] Stub 9pfs xattr functions for Windows Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 09/18] Dont initialize fields which aren't available on Windows Michael Fritscher
2017-11-06 14:26 ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 10/18] dirent has no d_off " Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 11/18] Sete ctx->xops to null " Michael Fritscher
2017-11-06 14:25 ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 12/18] Buildfix in 9p-util.c Michael Fritscher
2017-11-06 14:21 ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 13/18] fsetxattrat_nofollow doesn't seem to be defined on Windows - disable it Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 14/18] Disable rlimit under Windows Michael Fritscher
2017-11-06 14:24 ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 15/18] Fix unavailable fields in stbuf " Michael Fritscher
2017-11-06 14:36 ` Paolo Bonzini
2017-11-06 15:23 ` Michael Fritscher [this message]
2017-11-06 15:25 ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 16/18] Workaround for missing dent->d_type/d_off " Michael Fritscher
2017-11-06 14:32 ` Paolo Bonzini
2017-09-29 11:13 ` [Qemu-devel] [PATCH 17/18] Compile fixes for Windows Michael Fritscher
2017-09-29 11:13 ` [Qemu-devel] [PATCH 18/18] Enable 9pfs for Windows in configure / makefiles Michael Fritscher
2017-09-29 12:01 ` [Qemu-devel] Make 9pfs buildable for Windows Paolo Bonzini
2017-09-29 14:14 ` Michael Fritscher
2017-09-29 14:25 ` Paolo Bonzini
2017-09-29 18:09 ` Michael Fritscher
2017-10-01 16:17 ` Michael Fritscher
2017-10-15 19:02 ` Michael Fritscher
2017-10-15 19:13 ` Michael Fritscher
2017-10-15 19:50 ` Greg Kurz
2017-10-15 20:00 ` Michael Fritscher
2017-10-16 5:31 ` Michael Fritscher
2017-10-15 19:45 ` Greg Kurz
2017-11-06 13:29 ` Greg Kurz
2017-11-06 15:14 ` Michael Fritscher
2017-11-06 15:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bc62a3a54dd9c1eb19c41bc5f710e3e.squirrel@mifritscher.de \
--to=michael@fritscher.net \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).