From: Thomas Huth <thuth@redhat.com>
To: Yang Zhong <yang.zhong@intel.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, sameo@linux.intel.com, ehabkost@redhat.com,
peter.maydell@linaro.org,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 01/25] build: actually use CONFIG_PAM
Date: Thu, 3 Jan 2019 15:15:44 +0100 [thread overview]
Message-ID: <5bd93d20-08a3-e382-94a1-bf6529a5944c@redhat.com> (raw)
In-Reply-To: <20181227063419.12981-2-yang.zhong@intel.com>
Hi,
On 2018-12-27 07:33, Yang Zhong wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> Do not link it unconditionally into all binaries.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/pci-host/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-host/Makefile.objs b/hw/pci-host/Makefile.objs
> index 6d6597c065..9d7e7cd1b8 100644
> --- a/hw/pci-host/Makefile.objs
> +++ b/hw/pci-host/Makefile.objs
> @@ -1,4 +1,4 @@
> -common-obj-y += pam.o
> +common-obj-$(CONFIG_PAM) += pam.o
CONFIG_PAM has been removed in the default-configs with commit
a3b6e2bb71e6495a44f24e2296ab4feb4b6d4818
default-configs: remove CONFIG_PAM
... so if you want to use it now, you've got to revert that commit, too.
Thomas
next prev parent reply other threads:[~2019-01-03 14:15 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 6:33 [Qemu-devel] [RFC PATCH 00/25] Support Kconfig in QEMU Yang Zhong
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 01/25] build: actually use CONFIG_PAM Yang Zhong
2019-01-03 14:15 ` Thomas Huth [this message]
2019-01-07 11:29 ` Yang Zhong
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 02/25] hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards Yang Zhong
2019-01-03 14:30 ` Thomas Huth
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 03/25] minikconfig: add parser skeleton Yang Zhong
2019-01-04 13:36 ` Paolo Bonzini
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 04/25] minikconfig: add AST Yang Zhong
2019-01-04 14:13 ` Paolo Bonzini
2019-01-07 12:06 ` Yang Zhong
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 05/25] minikconfig: add semantic analysis Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 06/25] hw/display: make edid configurable Yang Zhong
2019-01-03 14:49 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 07/25] kconfig: introduce kconfig files Yang Zhong
2019-01-03 15:04 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 08/25] build: switch to Kconfig Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 09/25] ide: express dependencies with Kconfig Yang Zhong
2019-01-03 15:47 ` Thomas Huth
2019-01-08 5:22 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 10/25] build: convert pci.mak to Kconfig Yang Zhong
2019-01-03 16:06 ` Thomas Huth
2019-01-08 5:58 ` Yang Zhong
2019-01-04 13:48 ` Thomas Huth
2019-01-08 7:20 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 11/25] build: convert sound.mak " Yang Zhong
2019-01-04 13:26 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 12/25] build: convert usb.mak " Yang Zhong
2019-01-04 13:31 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 13/25] scsi: express dependencies with Kconfig Yang Zhong
2019-01-04 13:38 ` Paolo Bonzini
2019-01-08 7:32 ` Yang Zhong
2019-01-04 13:39 ` Thomas Huth
2019-01-08 8:04 ` Yang Zhong
2019-01-08 11:42 ` Paolo Bonzini
2019-01-11 3:08 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 14/25] bluetooth: " Yang Zhong
2019-01-04 13:41 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 15/25] isa: express dependencies with kconfig Yang Zhong
2019-01-04 13:55 ` Thomas Huth
2019-01-08 9:08 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 16/25] i386: express dependencies with Kconfig Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 17/25] i2c: " Yang Zhong
2019-01-04 15:30 ` Thomas Huth
2019-01-08 9:15 ` Yang Zhong
2019-01-08 11:46 ` Paolo Bonzini
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 18/25] ptimer: " Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 19/25] edid: express dependencies with kconfig Yang Zhong
2019-01-04 15:35 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 20/25] hyperv: " Yang Zhong
2019-01-04 15:38 ` Thomas Huth
2019-01-04 19:50 ` Paolo Bonzini
2019-01-08 10:38 ` Yang Zhong
2019-01-08 10:35 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 21/25] virtio: make virtio dependencies with Kconfig Yang Zhong
2019-01-04 19:54 ` Thomas Huth
2019-01-08 10:45 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 22/25] i386-softmmu.mak: remove all CONFIG_* except boards definitions Yang Zhong
2019-01-04 13:59 ` Paolo Bonzini
2019-01-08 10:53 ` Yang Zhong
2019-01-08 11:48 ` Paolo Bonzini
2019-01-11 2:22 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 23/25] x86_64-softmmu.mak: remove i386-softmmu.mak include Yang Zhong
2019-01-04 19:58 ` Thomas Huth
2019-01-08 10:55 ` Yang Zhong
2019-01-05 15:32 ` Peter Maydell
2019-01-08 10:58 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 24/25] minikconf: implement allyesconfig, allnoconfig, randconfig, defconfig Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 25/25] Makefile: only support defconfig Yang Zhong
2019-01-04 14:02 ` [Qemu-devel] [RFC PATCH 00/25] Support Kconfig in QEMU Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bd93d20-08a3-e382-94a1-bf6529a5944c@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sameo@linux.intel.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).