From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: famz@redhat.com, f4bug@amsat.org,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] tests/tcg: disable enterN insn tests for test-i386 with clang
Date: Tue, 9 Oct 2018 17:48:27 +0200 [thread overview]
Message-ID: <5bf2d666-d93b-1154-660c-3eab32350b8e@redhat.com> (raw)
In-Reply-To: <20181009145933.18925-4-alex.bennee@linaro.org>
On 09/10/2018 16:59, Alex Bennée wrote:
> The enter[qwl] instructions aren't supported by clang's inline
> assembler. Apply the hammer to work around it when we re-use our
> system compiler to build tcg tests.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Do you have a bug for this in llvm? It doesn't seem to be a good idea.
Paolo
> ---
> tests/tcg/i386/test-i386.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/tcg/i386/test-i386.c b/tests/tcg/i386/test-i386.c
> index c5f67000e4..da632c9b67 100644
> --- a/tests/tcg/i386/test-i386.c
> +++ b/tests/tcg/i386/test-i386.c
> @@ -2098,6 +2098,7 @@ long enter_stack[4096];
>
> static void test_enter(void)
> {
> +#if !(defined __clang__)
> #if defined(__x86_64__)
> TEST_ENTER("q", uint64_t, 0);
> TEST_ENTER("q", uint64_t, 1);
> @@ -2114,6 +2115,7 @@ static void test_enter(void)
> TEST_ENTER("w", uint16_t, 1);
> TEST_ENTER("w", uint16_t, 2);
> TEST_ENTER("w", uint16_t, 31);
> +#endif
> }
>
> #ifdef TEST_SSE
>
next prev parent reply other threads:[~2018-10-09 15:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 14:59 [Qemu-devel] [PATCH v2 0/3] Travis tweaks and tcg test fixes Alex Bennée
2018-10-09 14:59 ` [Qemu-devel] [PATCH v2 1/3] .travis.yml: split MacOSX builds and reduce target list Alex Bennée
2018-10-09 14:59 ` [Qemu-devel] [PATCH v2 2/3] tests/tcg: make test-i386 test program compile on clang Alex Bennée
2018-10-09 14:59 ` [Qemu-devel] [PATCH v2 3/3] tests/tcg: disable enterN insn tests for test-i386 with clang Alex Bennée
2018-10-09 15:48 ` Paolo Bonzini [this message]
2018-10-09 16:35 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bf2d666-d93b-1154-660c-3eab32350b8e@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).