qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 0/2] tracetool: fix log-stap format
Date: Tue, 5 Jan 2021 20:44:42 +0100	[thread overview]
Message-ID: <5bf99569-969f-c800-5eae-f6b40abd3ed8@redhat.com> (raw)
In-Reply-To: <20210105191721.120463-1-lvivier@redhat.com>

On 1/5/21 8:17 PM, Laurent Vivier wrote:
> The first patch fixes a problem I have introduced in vhost-vdpa
> traces by adding an unsupported format ("%llu").
> 
> The second patch fixes a problem I've seen while I was checking
> the result of the first patch: %PRI formats are not decoded
> correctly and we can end with things like "0x%u" because
> the used format is always the one of the first format of the string.
> 
> Laurent Vivier (2):
>   vhost-vdpa: fix "unsigned long long" error with stap
>   tracetool: fix "PRI" macro decoding
> 
>  hw/virtio/trace-events               | 2 +-
>  hw/virtio/vhost-vdpa.c               | 4 ++--
>  scripts/tracetool/format/log_stap.py | 1 +
>  3 files changed, 4 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



      parent reply	other threads:[~2021-01-05 19:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05 19:17 [PATCH 0/2] tracetool: fix log-stap format Laurent Vivier
2021-01-05 19:17 ` [PATCH 1/2] vhost-vdpa: fix "unsigned long long" error with stap Laurent Vivier
2021-01-06 12:45   ` Laurent Vivier
2021-01-05 19:17 ` [PATCH 2/2] tracetool: fix "PRI" macro decoding Laurent Vivier
2021-01-05 19:44   ` Philippe Mathieu-Daudé
2021-01-06  8:56     ` Laurent Vivier
2021-01-06 12:47   ` Daniel P. Berrangé
2021-01-13 15:14   ` Stefan Hajnoczi
2021-01-05 19:44 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bf99569-969f-c800-5eae-f6b40abd3ed8@redhat.com \
    --to=philmd@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).