From: Paolo Bonzini <pbonzini@redhat.com>
To: luoyonggang@gmail.com, qemu-level <qemu-devel@nongnu.org>
Cc: "QEMU Trivial" <qemu-trivial@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Laurent Vivier" <laurent@vivier.eu>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v5 0/4] Fixes curses on msys2/mingw
Date: Sat, 19 Sep 2020 17:03:00 +0200 [thread overview]
Message-ID: <5c0699e8-62ef-8f29-182f-a0744c727bae@redhat.com> (raw)
In-Reply-To: <CAE2XoE9Vf3Zixv6Ds0BmO9O5EWWjPbG-0EkP0BEbPikuCc4SVg@mail.gmail.com>
On 18/09/20 18:10, 罗勇刚(Yonggang Luo) wrote:
>
>> Yonggang Luo (4):
>> curses: Fixes compiler error that complain don't have langinfo.h on
>> msys2/mingw
>> curses: Fixes curses compiling errors.
>> win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE
>> are defined on msys2/mingw
>> configure: Fixes ncursesw detection under msys2/mingw by convert them
>> to meson
Hi, patches 1-3 are okay, but for patch 4 I think it's better to wait
for Meson 0.56 which will likely embed all the magic needed to test
curses (https://github.com/mesonbuild/meson/pull/7757).
Paolo
next prev parent reply other threads:[~2020-09-19 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 16:02 [PATCH v5 0/4] Fixes curses on msys2/mingw Yonggang Luo
2020-09-18 16:02 ` [PATCH v5 1/4] curses: Fixes compiler error that complain don't have langinfo.h " Yonggang Luo
2020-09-18 16:02 ` [PATCH v5 2/4] curses: Fixes curses compiling errors Yonggang Luo
2020-09-18 16:02 ` [PATCH v5 3/4] win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2/mingw Yonggang Luo
2020-09-18 16:02 ` [PATCH v5 4/4] configure: Fixes ncursesw detection under msys2/mingw by convert them to meson Yonggang Luo
2020-09-18 16:10 ` [PATCH v5 0/4] Fixes curses on msys2/mingw 罗勇刚(Yonggang Luo)
2020-09-19 15:03 ` Paolo Bonzini [this message]
2020-09-19 16:23 ` 罗勇刚(Yonggang Luo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c0699e8-62ef-8f29-182f-a0744c727bae@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=luoyonggang@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).