From: Connor Kuehl <ckuehl@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v2] block: Raise an error when backing file parameter is an empty string
Date: Thu, 13 Aug 2020 07:59:55 -0500 [thread overview]
Message-ID: <5c132353-886e-b818-bd04-58991ebe27f9@redhat.com> (raw)
In-Reply-To: <20200812065806.GA6587@linux.fritz.box>
On 8/12/20 1:58 AM, Kevin Wolf wrote:
> This looks like a test case that would be better served by not using
> QMPTestCase, but just printing the qemu-img output and having the
> message compared against the reference output.
>
> In fact, there is already 049 for testing some qemu-img create options
> and we could just add a line there (or multiple lines to cover other
> backing file related error cases, too).
>
> Putting it there would both simplify the test code and keep 298 free for
> the other series.
>
> None of the above is really a reason to reject the patch. I guess this
> is more of a "are you sure? (y/n)" before I apply it. :-)
Hi Kevin! Thanks for the review :-)
I think it'd be best for my own edification to address your comments
here instead of applying this now. I'll send a v3.
Connor
>
> Kevin
>
prev parent reply other threads:[~2020-08-13 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 21:23 [PATCH v2] block: Raise an error when backing file parameter is an empty string Connor Kuehl
2020-08-12 6:58 ` Kevin Wolf
2020-08-13 12:59 ` Connor Kuehl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c132353-886e-b818-bd04-58991ebe27f9@redhat.com \
--to=ckuehl@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).