From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73B78C433EF for ; Tue, 29 Mar 2022 14:47:59 +0000 (UTC) Received: from localhost ([::1]:59584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZD8Y-00069I-Ae for qemu-devel@archiver.kernel.org; Tue, 29 Mar 2022 10:47:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZD5j-00042o-Rv for qemu-devel@nongnu.org; Tue, 29 Mar 2022 10:45:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:54346) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZD5f-0000kK-7b for qemu-devel@nongnu.org; Tue, 29 Mar 2022 10:45:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648565098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BqAiok2sgOt2PKfdMzgveAKANUwwc8tkRT1e3d5u9UY=; b=ihU71G4zHWFr+41W8WzCEODu3RRB3swa1kgDArdcfEkc0L2EOeZRIW5vYMFFkFXYvGZqx/ nfcaBIHV8PPOecvO4RFY+wn/ofj7A4S+eliloenrmw7AoD9RIyOaNFnQ39hfidNrdvgemn 8Fv6DIfRCZUbRHJidjGAyp+5+G9LSJU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-251-NqjBSO5MOkyDW2naxN4hqQ-1; Tue, 29 Mar 2022 10:44:52 -0400 X-MC-Unique: NqjBSO5MOkyDW2naxN4hqQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0262185A5A8; Tue, 29 Mar 2022 14:44:52 +0000 (UTC) Received: from [10.33.192.183] (dhcp-192-183.str.redhat.com [10.33.192.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3A41840CFD02; Tue, 29 Mar 2022 14:44:50 +0000 (UTC) Message-ID: <5c250438-83c7-679b-edab-9704823df474@redhat.com> Date: Tue, 29 Mar 2022 16:44:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH 5/5] s390x/tcg: fix format-truncation warning To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= References: <20220328084717.367993-1-marcandre.lureau@redhat.com> <20220328084717.367993-6-marcandre.lureau@redhat.com> From: Thomas Huth In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , David Hildenbrand , Igor Mitsyanko , Cornelia Huck , Richard Henderson , qemu-devel , Beniamino Galvani , "open list:S390 SCLP-backed..." , qemu-arm , Antony Pavlov , Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 28/03/2022 12.22, Marc-André Lureau wrote: > Hi > > On Mon, Mar 28, 2022 at 12:59 PM Thomas Huth wrote: >> >> On 28/03/2022 10.47, marcandre.lureau@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> ../target/s390x/tcg/translate.c: In function ‘s390x_translate_init’: >>> ../target/s390x/tcg/translate.c:224:64: error: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size 3 [-Werror=format-truncation=] >>> 224 | snprintf(cpu_reg_names[i], sizeof(cpu_reg_names[0]), "r%d", i); >>> | ^~ >>> >>> Signed-off-by: Marc-André Lureau >>> --- >>> target/s390x/tcg/translate.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c >>> index 5acfc0ff9b4e..a082342a0424 100644 >>> --- a/target/s390x/tcg/translate.c >>> +++ b/target/s390x/tcg/translate.c >>> @@ -199,7 +199,7 @@ static TCGv_i64 regs[16]; >>> >>> void s390x_translate_init(void) >>> { >>> - int i; >>> + size_t i; >>> >>> psw_addr = tcg_global_mem_new_i64(cpu_env, >>> offsetof(CPUS390XState, psw.addr), >>> @@ -221,7 +221,7 @@ void s390x_translate_init(void) >>> "cc_vr"); >>> >>> for (i = 0; i < 16; i++) { >>> - snprintf(cpu_reg_names[i], sizeof(cpu_reg_names[0]), "r%d", i); >>> + snprintf(cpu_reg_names[i], sizeof(cpu_reg_names[0]), "r%zu", i); >> >> The compiler is *really* too stupid to see that i is in the range between 0 >> and 16 here??? ... that rather sounds like a compiler bug to me than >> something that we should work-around in the QEMU source code. Considering >> that you're using a x.0 release of GCC, please file a bug against GCC >> instead. If they refuse to fix it for GCC 12.1 or later, we can revisit this >> patch, but currently, I really think this should be fixed in GCC instead. >> > > I opened: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105080 Thanks! Looks like it will be fixed in the final release of GCC 12, so I think we can definitely drop this QEMU patch here. Thomas