From: Eric Blake <eblake@redhat.com>
To: Programmingkid <programmingkidx@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Markus Armbruster <armbru@redhat.com>
Cc: "qemu-devel@nongnu.org qemu-devel" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] Add more function keys to QEMU
Date: Thu, 27 Jul 2017 09:55:09 -0500 [thread overview]
Message-ID: <5c3214a0-196d-fa81-dbf8-237034b445de@redhat.com> (raw)
In-Reply-To: <1920BE03-56F6-4E44-B9D2-0638A86FACB2@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
On 07/27/2017 09:51 AM, Programmingkid wrote:
You forgot in-reply-to: and references: headers, meaning this was not
threaded with your 0/2 patch.
> There are now keyboards that have 19 function keys. This patch extends QEMU so these function keys can be used.
>
> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
> ---
> qapi-schema.json | 6 +++++-
> ui/input-keymap.c | 4 ++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
Conflicts with Gerd's pending UI pull; so you'll need to rebase.
Furthermore, while Gerd added keys after softfreeze (necessary to fix a
regression), your additions seem to be a new feature rather than a bug
fix, and may therefore be more appropriate for 2.11.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-07-27 14:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 14:51 [Qemu-devel] [PATCH 1/2] Add more function keys to QEMU Programmingkid
2017-07-27 14:54 ` Daniel P. Berrange
2017-07-28 2:36 ` Programmingkid
2017-07-28 8:15 ` Daniel P. Berrange
2017-07-27 14:55 ` Eric Blake [this message]
2017-07-28 2:37 ` Programmingkid
2017-07-28 12:01 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c3214a0-196d-fa81-dbf8-237034b445de@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).