From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Michael Tokarev" <mjt@tls.msk.ru>,
qemu-trivial@nongnu.org,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Greg Kurz" <groug@kaod.org>, "Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH 4/6] hw/ppc/e500: Prefer local variable over qdev_get_machine()
Date: Fri, 16 Dec 2022 17:30:36 +0100 [thread overview]
Message-ID: <5c3c7f39-1e73-efdb-25c9-117cda9013c9@linaro.org> (raw)
In-Reply-To: <20221216145709.271940-5-shentey@gmail.com>
On 16/12/22 15:57, Bernhard Beschow wrote:
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
> hw/ppc/e500.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
> index 2fe496677c..ad83924004 100644
> --- a/hw/ppc/e500.c
> +++ b/hw/ppc/e500.c
> @@ -959,7 +959,7 @@ void ppce500_init(MachineState *machine)
> memory_region_add_subregion(address_space_mem, 0, machine->ram);
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2022-12-16 16:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 14:57 [PATCH 0/6] Trivial PPC cleanups Bernhard Beschow
2022-12-16 14:57 ` [PATCH 1/6] target/ppc/mmu_common: Log which effective address had no TLB entry found Bernhard Beschow
2022-12-16 16:24 ` Philippe Mathieu-Daudé
2022-12-16 14:57 ` [PATCH 2/6] target/ppc/mmu_common: Fix table layout of "info tlb" HMP command Bernhard Beschow
2022-12-16 16:24 ` Philippe Mathieu-Daudé
2022-12-16 14:57 ` [PATCH 3/6] hw/ppc/virtex_ml507: Prefer local over global variable Bernhard Beschow
2022-12-16 15:54 ` Edgar E. Iglesias
2022-12-16 16:28 ` Philippe Mathieu-Daudé
2022-12-16 14:57 ` [PATCH 4/6] hw/ppc/e500: Prefer local variable over qdev_get_machine() Bernhard Beschow
2022-12-16 15:06 ` BALATON Zoltan
2022-12-16 16:30 ` Philippe Mathieu-Daudé [this message]
2022-12-16 14:57 ` [PATCH 5/6] hw/ppc/e500: Resolve variable shadowing Bernhard Beschow
2022-12-16 14:57 ` [PATCH 6/6] hw/ppc/e500: Move comment to more appropriate place Bernhard Beschow
2022-12-16 15:32 ` [PATCH 0/6] Trivial PPC cleanups Cédric Le Goater
2022-12-16 16:04 ` Bernhard Beschow
2022-12-16 17:50 ` Daniel Henrique Barboza
2022-12-20 22:40 ` Bernhard Beschow
2022-12-20 22:53 ` Bernhard Beschow
2022-12-21 10:27 ` Daniel Henrique Barboza
2022-12-21 17:04 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c3c7f39-1e73-efdb-25c9-117cda9013c9@linaro.org \
--to=philmd@linaro.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=groug@kaod.org \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).