From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Pavel Dovgalyuk <dovgaluk@ispras.ru>
Cc: quintela@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com,
rth@twiddle.net
Subject: Re: [Qemu-devel] i386: EFER vs 32-bit CPU
Date: Wed, 29 May 2019 13:39:36 +0200 [thread overview]
Message-ID: <5c55c39b-694b-5d4e-d420-5df0feabc1e8@redhat.com> (raw)
In-Reply-To: <20190529113045.GE2882@work-vm>
On 29/05/19 13:30, Dr. David Alan Gilbert wrote:
>> Should we add a section for i386, which duplicates efer, or just version_id of the main VMSD should
>> be updated?
>
> You could do:
>
> #ifdef TARGET_X86_64
> VMSTATE_UINT64(env.efer, X86CPU),
> VMSTATE_UINT64(env.star, X86CPU),
> ...
>
> to become:
>
> VMSTATE_UINT64_TEST(env.efer, X86CPU, efer_needed)
> #ifdef TARGET_X86_64
> VMSTATE_UINT64(env.star, X86CPU),
>
>
> and then make efer_needed a function that returns true if
> TARGET_X86_64 or it's a new machine type that knows about whatever
> you're going to do with it.
I prefer adding a subsection for 32-bit, so that EFER is saved/restored
if nonzero.
Paolo
next prev parent reply other threads:[~2019-05-29 11:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 11:26 [Qemu-devel] i386: EFER vs 32-bit CPU Pavel Dovgalyuk
2019-05-29 11:30 ` Dr. David Alan Gilbert
2019-05-29 11:39 ` Paolo Bonzini [this message]
2019-05-29 11:53 ` Pavel Dovgalyuk
2019-05-29 12:36 ` Dr. David Alan Gilbert
2019-05-29 14:03 ` Pavel Dovgalyuk
2019-05-30 0:52 ` Peter Xu
2019-05-30 5:54 ` Pavel Dovgalyuk
2019-05-30 9:00 ` Peter Xu
2019-05-30 9:04 ` Peter Xu
2019-05-30 11:00 ` TeLeMan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c55c39b-694b-5d4e-d420-5df0feabc1e8@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).