From: Laurent Vivier <laurent@vivier.eu>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: Re: [PATCH 1/2] linux-user/alpha: Fix rt sigframe return
Date: Thu, 22 Apr 2021 20:23:02 +0200 [thread overview]
Message-ID: <5c79ca76-8b66-eba0-9acf-9077957d0945@vivier.eu> (raw)
In-Reply-To: <20210422180819.252121-2-richard.henderson@linaro.org>
Le 22/04/2021 à 20:08, Richard Henderson a écrit :
> We incorrectly used the offset of the non-rt sigframe.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/alpha/signal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/alpha/signal.c b/linux-user/alpha/signal.c
> index c5c27ce084..86f5d2276d 100644
> --- a/linux-user/alpha/signal.c
> +++ b/linux-user/alpha/signal.c
> @@ -200,7 +200,7 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,
> &frame->retcode[1]);
> __put_user(INSN_CALLSYS, &frame->retcode[2]);
> /* imb(); */
> - r26 = frame_addr + offsetof(struct target_sigframe, retcode);
> + r26 = frame_addr + offsetof(struct target_rt_sigframe, retcode);
> }
>
> if (err) {
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2021-04-22 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 18:08 [PATCH 0/2] linux-user: sigaction fixes/cleanups Richard Henderson
2021-04-22 18:08 ` [PATCH 1/2] linux-user/alpha: Fix rt sigframe return Richard Henderson
2021-04-22 18:23 ` Laurent Vivier [this message]
2021-04-22 19:26 ` Philippe Mathieu-Daudé
2021-04-22 18:08 ` [PATCH 2/2] linux-user: Clean up sigaction ka_restorer Richard Henderson
2021-04-22 20:27 ` Richard Henderson
2021-04-22 18:18 ` [PATCH 0/2] linux-user: sigaction fixes/cleanups no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c79ca76-8b66-eba0-9acf-9077957d0945@vivier.eu \
--to=laurent@vivier.eu \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).