From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] tcg: Introduce tcg_remove_ops_after
Date: Mon, 7 Jun 2021 08:22:46 -0700 [thread overview]
Message-ID: <5c934f15-765e-d3bc-7ea7-9aa112d1fd39@linaro.org> (raw)
In-Reply-To: <CAFEAcA-EFkuWb8aHhiiN7Wu9n302A8hdoHUzn7txOVhEyOX=Fg@mail.gmail.com>
On 6/7/21 6:51 AM, Peter Maydell wrote:
>> +void tcg_remove_ops_after(TCGOp *op);
>
> A doc comment would be nice.
Fair enough.
> This looks OK as far as TCG proper goes, but is it going to confuse
> the TCG plugin infrastructure if a frontend generates a bunch of
> TCG IR and then winds back the insn stream and generates something
> else instead ? I see some calls from tcg/ into plugin related
> functions, so I'm not sure...
Mm. Didn't think about that Friday. But looking now, if you wind back to
dc->insn_start, everything will be fine.
The plugin stuff will put stuff in the stream, and then go back and
post-process it. But it does not record anything on the side, so if the stuff
is no longer in the stream all's well.
r~
prev parent reply other threads:[~2021-06-07 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 21:27 [PATCH] tcg: Introduce tcg_remove_ops_after Richard Henderson
2021-06-07 13:51 ` Peter Maydell
2021-06-07 15:22 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c934f15-765e-d3bc-7ea7-9aa112d1fd39@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).