From: Laurent Vivier <lvivier@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH] passt: Declare dependency on gio
Date: Tue, 23 Sep 2025 14:52:16 +0200 [thread overview]
Message-ID: <5c952898-c129-426f-a68f-42b369ca7aa7@redhat.com> (raw)
In-Reply-To: <20250922132217.680404-1-peter.maydell@linaro.org>
On 22/09/2025 15:22, Peter Maydell wrote:
> The passt network backend uses gio; declare this dependency in
> meson.build, so we don't try to build it if configured with
> --disable-gio or if gio is not present.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 854ee02b222 ("net: Add passt network backend")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3121
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> meson.build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meson.build b/meson.build
> index 6ade30f36ad..c5a56ba5deb 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1279,6 +1279,7 @@ if not get_option('slirp').auto() or have_system
> endif
>
> enable_passt = get_option('passt') \
> + .require(gio.found(), error_message: 'passt requires gio') \
> .require(host_os == 'linux', error_message: 'passt is supported only on Linux') \
> .allowed()
>
I sent the same patch two months ago:
https://lists.nongnu.org/archive/html/qemu-devel/2025-07/msg04907.html
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Laurent
next prev parent reply other threads:[~2025-09-23 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 13:22 [PATCH] passt: Declare dependency on gio Peter Maydell
2025-09-23 12:52 ` Laurent Vivier [this message]
2025-09-25 10:12 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c952898-c129-426f-a68f-42b369ca7aa7@redhat.com \
--to=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).