qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 0/6] monitor: enable OOB by default
Date: Wed, 10 Oct 2018 15:27:34 -0500	[thread overview]
Message-ID: <5ca812f7-c574-36fc-c7cd-f11e71a0efc1@redhat.com> (raw)
In-Reply-To: <049fc618-6e13-5030-4124-1c9f4315f7eb@redhat.com>

On 10/10/18 2:26 PM, Eric Blake wrote:

> 
> On the other hand, when I'm trying to use a qemu binary with these 
> patches applied, libvirt is hanging when trying to probe the 
> capabilities of the binary, waiting for a response to 
> "qmp_capabilities". I'll try and bisect which patch is causing the 
> problem, and figure out why it is happening for libvirt and not running 
> by hand (perhaps is it a tty vs. Unix socket thing?)

Bisect didn't help much; it landed on:

     monitor: remove "x-oob", turn oob on by default

as the cause of libvirt hanging. I didn't have time to investigate 
further, other than the command line that is hanging:

/home/eblake/qemu/x86_64-softmmu/qemu-system-x86_64 -S -no-user-config 
-nodefaults -nographic -machine none,accel=kvm:tcg -qmp 
unix:/var/lib/libvirt/qemu/capabilities.monitor.sock,server,nowait 
-pidfile /var/lib/libvirt/qemu/capabilities.pidfile -daemonize

And I suspect it is the -daemonize that is causing the hang I'm seeing 
when run by libvirt.

> Based-on: <20180828191048.29806-1-armbru@redhat.com>
> Based-on: <20180901111716.1675-1-armbru@redhat.com>
> 
> (this series is based on Markus's monitor-next tree)


Am I missing any prerequisite patches? Markus' monitor-next tree is 
currently a subset of git master (merge efd1d522).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  reply	other threads:[~2018-10-10 20:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09  6:27 [Qemu-devel] [PATCH v9 0/6] monitor: enable OOB by default Peter Xu
2018-10-09  6:27 ` [Qemu-devel] [PATCH v9 1/6] monitor: Suspend monitor instead dropping commands Peter Xu
2018-10-31 14:01   ` Markus Armbruster
2018-10-09  6:27 ` [Qemu-devel] [PATCH v9 2/6] monitor: resume the monitor earlier if needed Peter Xu
2018-10-09  8:54   ` Marc-André Lureau
2018-10-10  3:21     ` Peter Xu
2018-10-29 11:10       ` Marc-André Lureau
2018-10-09  6:27 ` [Qemu-devel] [PATCH v9 3/6] monitor: remove "x-oob", turn oob on by default Peter Xu
2018-10-09  6:27 ` [Qemu-devel] [PATCH v9 4/6] Revert "tests: Add parameter to qtest_init_without_qmp_handshake" Peter Xu
2018-10-09  6:27 ` [Qemu-devel] [PATCH v9 5/6] tests: add oob functional test for test-qmp-cmds Peter Xu
2018-10-09  6:27 ` [Qemu-devel] [PATCH v9 6/6] tests: qmp-test: add queue full test Peter Xu
2018-10-10 16:26 ` [Qemu-devel] [PATCH v9 0/6] monitor: enable OOB by default Eric Blake
2018-10-10 19:26   ` Eric Blake
2018-10-10 20:27     ` Eric Blake [this message]
2018-10-11  0:05       ` Peter Xu
2018-10-11  1:17         ` Eric Blake
2018-10-11  2:26           ` Peter Xu
2018-10-31 13:59 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ca812f7-c574-36fc-c7cd-f11e71a0efc1@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).