From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAL5C-0008RD-6s for qemu-devel@nongnu.org; Wed, 10 Oct 2018 16:27:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gAL57-0005DO-7A for qemu-devel@nongnu.org; Wed, 10 Oct 2018 16:27:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35392) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gAL53-00059b-MK for qemu-devel@nongnu.org; Wed, 10 Oct 2018 16:27:43 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CD8D13083395 for ; Wed, 10 Oct 2018 20:27:40 +0000 (UTC) References: <20181009062718.1914-1-peterx@redhat.com> <902c92e2-3454-771e-51ff-ab38b970e86e@redhat.com> <049fc618-6e13-5030-4124-1c9f4315f7eb@redhat.com> From: Eric Blake Message-ID: <5ca812f7-c574-36fc-c7cd-f11e71a0efc1@redhat.com> Date: Wed, 10 Oct 2018 15:27:34 -0500 MIME-Version: 1.0 In-Reply-To: <049fc618-6e13-5030-4124-1c9f4315f7eb@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v9 0/6] monitor: enable OOB by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Markus Armbruster , "Dr . David Alan Gilbert" On 10/10/18 2:26 PM, Eric Blake wrote: > > On the other hand, when I'm trying to use a qemu binary with these > patches applied, libvirt is hanging when trying to probe the > capabilities of the binary, waiting for a response to > "qmp_capabilities". I'll try and bisect which patch is causing the > problem, and figure out why it is happening for libvirt and not running > by hand (perhaps is it a tty vs. Unix socket thing?) Bisect didn't help much; it landed on: monitor: remove "x-oob", turn oob on by default as the cause of libvirt hanging. I didn't have time to investigate further, other than the command line that is hanging: /home/eblake/qemu/x86_64-softmmu/qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -machine none,accel=kvm:tcg -qmp unix:/var/lib/libvirt/qemu/capabilities.monitor.sock,server,nowait -pidfile /var/lib/libvirt/qemu/capabilities.pidfile -daemonize And I suspect it is the -daemonize that is causing the hang I'm seeing when run by libvirt. > Based-on: <20180828191048.29806-1-armbru@redhat.com> > Based-on: <20180901111716.1675-1-armbru@redhat.com> > > (this series is based on Markus's monitor-next tree) Am I missing any prerequisite patches? Markus' monitor-next tree is currently a subset of git master (merge efd1d522). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org