From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 663E3C2B9F8 for ; Tue, 25 May 2021 16:48:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F6EC61417 for ; Tue, 25 May 2021 16:48:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F6EC61417 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llaDz-0001Zk-P6 for qemu-devel@archiver.kernel.org; Tue, 25 May 2021 12:48:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llZgq-0002Nv-Fn for qemu-devel@nongnu.org; Tue, 25 May 2021 12:13:56 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:10874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llZgn-0003iS-R7 for qemu-devel@nongnu.org; Tue, 25 May 2021 12:13:56 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14PG3IJ4022537; Tue, 25 May 2021 12:13:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=mIbHTeYLZZEoYK51ATdCljcCsBc884gzdxA0uwd5k9I=; b=I+LqDJjfCWJw7HDH+T9eOGecioxuXTqSJxgvpX+oO8yrozpTyYEFhiq/7S7MAzF9GK8V ZEofACHetliTNPUJ1C+tt7uDhiQ5e5bstTirSkg8U2D80D+EXVXW3zBsTbTdK0GKllNM H6KtnPC0vtT/UXxlAl4O2oyNknFkI0rxA0EG7fhKrctALPKuhFwCGfQ1Uht6hRKeV43q 83mpTqVeGF7Wyw9wQ1Pshpz80qC8Hdz6oi/zNifMCm2+oh60g2CJdOFHDoGvH1+JmC02 Lpjc0b1ABnDkFLDM7sZ3jW0Qv2qteOwzgkrH1Of/+lPUe43+Df5EliS53sk60OCPJnVt 2Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 38s2credyv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 May 2021 12:13:50 -0400 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 14PG3eLm024364; Tue, 25 May 2021 12:13:49 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 38s2credyf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 May 2021 12:13:49 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 14PG91eB016208; Tue, 25 May 2021 16:13:49 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma01dal.us.ibm.com with ESMTP id 38s1m220m2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 May 2021 16:13:48 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 14PGDlrI31195498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 May 2021 16:13:47 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DE6F8112066; Tue, 25 May 2021 16:13:47 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CE0CB112065; Tue, 25 May 2021 16:13:47 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 25 May 2021 16:13:47 +0000 (GMT) Subject: Re: [PATCH 6/6] tests/unit/test-vmstate: Assert that dup() and mkstemp() succeed To: Peter Maydell , qemu-devel@nongnu.org References: <20210525134458.6675-1-peter.maydell@linaro.org> <20210525134458.6675-7-peter.maydell@linaro.org> From: Stefan Berger Message-ID: <5cabc8b9-f3ac-1179-a099-e7cebbe9f86f@linux.ibm.com> Date: Tue, 25 May 2021 12:13:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210525134458.6675-7-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-GUID: LBIveh4ti-8WDKlwZUigykCKOc6Q6ZuC X-Proofpoint-ORIG-GUID: HUoRm0q-GfixV83rNMyyRu6ZCnJgVruB X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-25_07:2021-05-25, 2021-05-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 adultscore=0 spamscore=0 mlxscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105250098 Received-SPF: pass client-ip=148.163.158.5; envelope-from=stefanb@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Stefan Berger , "Michael S. Tsirkin" , Paolo Bonzini , Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/25/21 9:44 AM, Peter Maydell wrote: > Coverity complains that we don't check for failures from dup() > and mkstemp(); add asserts that these syscalls succeeded. > > Fixes: Coverity CID 1432516, 1432574 > Signed-off-by: Peter Maydell Reviewed-by: Stefan Berger > --- > tests/unit/test-vmstate.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c > index a001879585e..8d46af61511 100644 > --- a/tests/unit/test-vmstate.c > +++ b/tests/unit/test-vmstate.c > @@ -44,6 +44,7 @@ static QEMUFile *open_test_file(bool write) > QIOChannel *ioc; > QEMUFile *f; > > + g_assert(fd >= 0); > lseek(fd, 0, SEEK_SET); > if (write) { > g_assert_cmpint(ftruncate(fd, 0), ==, 0); > @@ -1486,6 +1487,7 @@ int main(int argc, char **argv) > g_autofree char *temp_file = g_strdup_printf("%s/vmst.test.XXXXXX", > g_get_tmp_dir()); > temp_fd = mkstemp(temp_file); > + g_assert(temp_fd >= 0); > > module_call_init(MODULE_INIT_QOM); >