qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Yi Min Zhao <zyimin@linux.vnet.ibm.com>,
	Cornelia Huck <cohuck@redhat.com>
Cc: Halil Pasic <pasic@linux.vnet.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Alexander Graf <agraf@suse.de>,
	"Jason J . Herne" <jjherne@linux.vnet.ibm.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when migration is available
Date: Wed, 27 Sep 2017 09:02:48 +0200	[thread overview]
Message-ID: <5caeb93d-b436-d8c0-2706-fd3476b54ad0@de.ibm.com> (raw)
In-Reply-To: <7134b571-41dd-97c8-85b8-fb623babb016@linux.vnet.ibm.com>



On 09/27/2017 07:45 AM, Yi Min Zhao wrote:
> 
> 
> 在 2017/9/26 下午9:36, Christian Borntraeger 写道:
>> @@ -557,6 +557,12 @@ static void kvm_s390_flic_realize(DeviceState *dev, Error **errp)
>>       test_attr.group = KVM_DEV_FLIC_CLEAR_IO_IRQ;
>>       flic_state->clear_io_supported = !ioctl(flic_state->fd,
>>                                               KVM_HAS_DEVICE_ATTR, test_attr);
>> +    /* try enable the AIS facility */
>> +    test_attr.group = KVM_DEV_FLIC_AISM_ALL;
>> +    if (!ioctl(flic_state->fd, KVM_HAS_DEVICE_ATTR, test_attr)) {
>> +            kvm_vm_enable_cap(kvm_state, KVM_CAP_S390_AIS, 0);

yes, will fix.


> Is there an indention error?
> Except this, the code LGTM.
>> +    }
>> +
>>       return;
> 

  reply	other threads:[~2017-09-27  7:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-26 13:36 [Qemu-devel] [PATCH v2 0/2] ais fixups for 2.11 Christian Borntraeger
2017-09-26 13:36 ` [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when migration is available Christian Borntraeger
2017-09-26 13:43   ` David Hildenbrand
2017-09-26 14:06     ` Christian Borntraeger
2017-09-26 14:08       ` David Hildenbrand
2017-09-27  4:35       ` Yi Min Zhao
2017-09-27  5:45   ` Yi Min Zhao
2017-09-27  7:02     ` Christian Borntraeger [this message]
2017-09-26 13:36 ` [Qemu-devel] [PATCH v2 2/2] s390x/ais: disable ais for compat machines Christian Borntraeger
2017-09-26 13:51   ` David Hildenbrand
2017-09-27  7:12     ` Christian Borntraeger
2017-09-27  8:03       ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5caeb93d-b436-d8c0-2706-fd3476b54ad0@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=jjherne@linux.vnet.ibm.com \
    --cc=pasic@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=zyimin@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).