From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: David Hildenbrand <david@redhat.com>,
Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
Ilya Leoshkevich <iii@linux.ibm.com>,
qemu-s390x@nongnu.org, Peter Xu <peterx@redhat.com>,
Matthew Rosato <mjrosato@linux.ibm.com>
Subject: Re: [PATCH 5/5] target/s390x/tcg/excp_helper: Restrict system headers to sysemu
Date: Sat, 17 Dec 2022 12:51:32 +0100 [thread overview]
Message-ID: <5cc7ac52-29a8-8d7a-1d66-0a8015f4065e@linaro.org> (raw)
In-Reply-To: <e20a4f2e-2e97-87b8-495f-cc3ca95cfe0d@linaro.org>
On 17/12/22 01:45, Richard Henderson wrote:
> On 12/16/22 14:04, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> target/s390x/tcg/excp_helper.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/target/s390x/tcg/excp_helper.c
>> b/target/s390x/tcg/excp_helper.c
>> index fe02d82201..e9eb7c455e 100644
>> --- a/target/s390x/tcg/excp_helper.c
>> +++ b/target/s390x/tcg/excp_helper.c
>> @@ -21,15 +21,15 @@
>> #include "qemu/osdep.h"
>> #include "qemu/log.h"
>> #include "cpu.h"
>> -#include "s390x-internal.h"
>> #include "exec/helper-proto.h"
>> -#include "qemu/timer.h"
>> #include "exec/exec-all.h"
>> -#include "exec/cpu_ldst.h"
>> -#include "hw/s390x/ioinst.h"
>> -#include "exec/address-spaces.h"
>> +#include "s390x-internal.h"
>> #include "tcg_s390x.h"
>> #ifndef CONFIG_USER_ONLY
>> +#include "qemu/timer.h"
>> +#include "exec/cpu_ldst.h"
>
> cpu_ldst.h is not a system header. The others look plausible.
Oops, correct.
prev parent reply other threads:[~2022-12-17 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 22:04 [PATCH 0/5] target/s390x: Header cleanups around "cpu.h" Philippe Mathieu-Daudé
2022-12-16 22:04 ` [PATCH 1/5] exec/memory: Expose memory_region_access_valid() Philippe Mathieu-Daudé
2022-12-17 0:42 ` Richard Henderson
2022-12-16 22:04 ` [PATCH 2/5] hw/s390x/pv: Un-inline s390_pv_init() Philippe Mathieu-Daudé
2022-12-16 23:27 ` Philippe Mathieu-Daudé
2022-12-16 22:04 ` [PATCH 3/5] hw/s390x/pv: Simplify s390_is_pv() for user emulation Philippe Mathieu-Daudé
2022-12-17 11:42 ` Philippe Mathieu-Daudé
2022-12-16 22:04 ` [PATCH 4/5] target/s390x/tcg/misc_helper: Remove unused "memory.h" include Philippe Mathieu-Daudé
2022-12-17 0:43 ` Richard Henderson
2022-12-16 22:04 ` [PATCH 5/5] target/s390x/tcg/excp_helper: Restrict system headers to sysemu Philippe Mathieu-Daudé
2022-12-17 0:45 ` Richard Henderson
2022-12-17 11:51 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cc7ac52-29a8-8d7a-1d66-0a8015f4065e@linaro.org \
--to=philmd@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).