From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cayWI-0006YW-H0 for qemu-devel@nongnu.org; Tue, 07 Feb 2017 00:40:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cayWF-0006FE-Ey for qemu-devel@nongnu.org; Tue, 07 Feb 2017 00:40:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47078) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cayWF-0006Eq-91 for qemu-devel@nongnu.org; Tue, 07 Feb 2017 00:40:47 -0500 References: <1486110164-13797-1-git-send-email-peterx@redhat.com> <1486110164-13797-9-git-send-email-peterx@redhat.com> From: Jason Wang Message-ID: <5ccb8227-6532-f330-8c6a-48b62a19e372@redhat.com> Date: Tue, 7 Feb 2017 13:40:39 +0800 MIME-Version: 1.0 In-Reply-To: <1486110164-13797-9-git-send-email-peterx@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 08/18] intel_iommu: fix trace for addr translation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: tianyu.lan@intel.com, kevin.tian@intel.com, mst@redhat.com, jan.kiszka@siemens.com, David Gibson , alex.williamson@redhat.com, bd.aviv@gmail.com On 2017=E5=B9=B402=E6=9C=8803=E6=97=A5 16:22, Peter Xu wrote: > Another patch to convert the DPRINTF() stuffs. This patch focuses on th= e > address translation path and caching. > > Signed-off-by: Peter Xu > --- > hw/i386/intel_iommu.c | 84 ++++++++++++++++++++----------------------= --------- > hw/i386/trace-events | 7 +++++ > 2 files changed, 39 insertions(+), 52 deletions(-) Similar to previous patch, this in fact a conversion not a fix. > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index d7b9a01..c672621 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -260,11 +260,9 @@ static void vtd_update_iotlb(IntelIOMMUState *s, u= int16_t source_id, > uint64_t *key =3D g_malloc(sizeof(*key)); > uint64_t gfn =3D vtd_get_iotlb_gfn(addr, level); > =20 > - VTD_DPRINTF(CACHE, "update iotlb sid 0x%"PRIx16 " iova 0x%"PRIx64 > - " slpte 0x%"PRIx64 " did 0x%"PRIx16, source_id, addr, = slpte, > - domain_id); > + trace_vtd_iotlb_page_update(source_id, addr, slpte, domain_id); > if (g_hash_table_size(s->iotlb) >=3D VTD_IOTLB_MAX_SIZE) { > - VTD_DPRINTF(CACHE, "iotlb exceeds size limit, forced to reset"= ); > + trace_vtd_iotlb_reset("iotlb exceeds size limit"); > vtd_reset_iotlb(s); > } > =20 > @@ -505,8 +503,7 @@ static int vtd_get_root_entry(IntelIOMMUState *s, u= int8_t index, > =20 > addr =3D s->root + index * sizeof(*re); > if (dma_memory_read(&address_space_memory, addr, re, sizeof(*re))= ) { > - VTD_DPRINTF(GENERAL, "error: fail to access root-entry at 0x%"= PRIx64 > - " + %"PRIu8, s->root, index); > + trace_vtd_err("Fail to access root-entry"); Looks like some information were removed which may be valuable for=20 debugging, any reason for do this? > re->val =3D 0; > return -VTD_FR_ROOT_TABLE_INV; > } [...]