From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
Jeff Cody <jcody@redhat.com>,
mreitz@redhat.com, jjherne@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v4 4/5] mirror: follow AioContext change gracefully
Date: Wed, 15 Jun 2016 10:57:49 +0200 [thread overview]
Message-ID: <5cd43fbb-b9ef-ba1c-ea33-a0abf91346ec@redhat.com> (raw)
In-Reply-To: <1465928228-1184-5-git-send-email-stefanha@redhat.com>
On 14/06/2016 20:17, Stefan Hajnoczi wrote:
> +/* There is no matching mirror_resume() because mirror_run() will begin
> + * iterating again when the job is resumed.
> + */
> +static void mirror_pause(BlockJob *job)
> +{
> + MirrorBlockJob *s = container_of(job, MirrorBlockJob, common);
> +
> + while (s->in_flight > 0) {
> + aio_poll(blk_get_aio_context(job->blk), true);
> + }
This is calling aio_poll from a coroutine, which is ugly -- see Fam's
recent introduction of bdrv_co_drain. I think this should call
mirror_drain instead.
Paolo
> +}
> +
next prev parent reply other threads:[~2016-06-15 8:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 18:17 [Qemu-devel] [PATCH v4 0/5] blockjob: AioContext change support for mirror and backup Stefan Hajnoczi
2016-06-14 18:17 ` [Qemu-devel] [PATCH v4 1/5] blockjob: move iostatus reset out of block_job_enter() Stefan Hajnoczi
2016-06-15 8:47 ` Fam Zheng
2016-06-14 18:17 ` [Qemu-devel] [PATCH v4 2/5] blockjob: add pause points Stefan Hajnoczi
2016-06-15 8:53 ` Paolo Bonzini
2016-06-16 13:17 ` Stefan Hajnoczi
2016-06-16 13:24 ` Paolo Bonzini
2016-06-15 8:57 ` Fam Zheng
2016-06-15 9:01 ` Paolo Bonzini
2016-06-16 10:19 ` Stefan Hajnoczi
2016-06-14 18:17 ` [Qemu-devel] [PATCH v4 3/5] blockjob: add AioContext attached callback Stefan Hajnoczi
2016-06-15 9:05 ` Fam Zheng
2016-06-16 10:13 ` Stefan Hajnoczi
2016-06-14 18:17 ` [Qemu-devel] [PATCH v4 4/5] mirror: follow AioContext change gracefully Stefan Hajnoczi
2016-06-15 8:57 ` Paolo Bonzini [this message]
2016-06-16 10:17 ` Stefan Hajnoczi
2016-06-16 10:21 ` Paolo Bonzini
2016-06-16 11:28 ` Stefan Hajnoczi
2016-06-14 18:17 ` [Qemu-devel] [PATCH v4 5/5] backup: " Stefan Hajnoczi
2016-06-14 19:06 ` [Qemu-devel] [PATCH v4 0/5] blockjob: AioContext change support for mirror and backup Jason J. Herne
2016-06-15 8:56 ` Stefan Hajnoczi
2016-06-15 8:59 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cd43fbb-b9ef-ba1c-ea33-a0abf91346ec@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).