[PATCH] aspeed/{xdma, rtc, sdhci}: Fix endianness to DEVICE_LITTLE_ENDIAN

[PATCH] aspeed/{xdma, rtc, sdhci}: Fix endianness to DEVICE_LITTLE_ENDIAN

[Cédric Le Goater via]

When the XDMA, RTC and SDHCI device models of the Aspeed SoCs were
first introduced, their MMIO regions inherited of a DEVICE_NATIVE_ENDIAN
endianness. It should be DEVICE_LITTLE_ENDIAN. Fix that.

Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
 hw/misc/aspeed_xdma.c | 2 +-
 hw/rtc/aspeed_rtc.c   | 2 +-
 hw/sd/aspeed_sdhci.c  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/misc/aspeed_xdma.c b/hw/misc/aspeed_xdma.c
index 31662ea0f5cc..d9afb0cae1f7 100644
--- a/hw/misc/aspeed_xdma.c
+++ b/hw/misc/aspeed_xdma.c
@@ -113,7 +113,7 @@ static void aspeed_xdma_write(void *opaque, hwaddr addr, uint64_t val,
 static const MemoryRegionOps aspeed_xdma_ops = {
     .read = aspeed_xdma_read,
     .write = aspeed_xdma_write,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
     .valid.min_access_size = 1,
     .valid.max_access_size = 4,
 };
diff --git a/hw/rtc/aspeed_rtc.c b/hw/rtc/aspeed_rtc.c
index c4feea23a0b3..6793e253f472 100644
--- a/hw/rtc/aspeed_rtc.c
+++ b/hw/rtc/aspeed_rtc.c
@@ -131,7 +131,7 @@ static void aspeed_rtc_reset(DeviceState *d)
 static const MemoryRegionOps aspeed_rtc_ops = {
     .read = aspeed_rtc_read,
     .write = aspeed_rtc_write,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
 };
 
 static const VMStateDescription vmstate_aspeed_rtc = {
diff --git a/hw/sd/aspeed_sdhci.c b/hw/sd/aspeed_sdhci.c
index 7217e20c2a98..339a8d12df26 100644
--- a/hw/sd/aspeed_sdhci.c
+++ b/hw/sd/aspeed_sdhci.c
@@ -124,7 +124,7 @@ static void aspeed_sdhci_write(void *opaque, hwaddr addr, uint64_t val,
 static const MemoryRegionOps aspeed_sdhci_ops = {
     .read = aspeed_sdhci_read,
     .write = aspeed_sdhci_write,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
     .valid.min_access_size = 1,
     .valid.max_access_size = 4,
 };
-- 
2.51.1

Re: [PATCH] aspeed/{xdma,rtc,sdhci}: Fix endianness to DEVICE_LITTLE_ENDIAN

[Philippe Mathieu-Daudé]

On 25/11/25 15:26, Cédric Le Goater wrote:
> When the XDMA, RTC and SDHCI device models of the Aspeed SoCs were
> first introduced, their MMIO regions inherited of a DEVICE_NATIVE_ENDIAN
> endianness. It should be DEVICE_LITTLE_ENDIAN. Fix that.
> 
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   hw/misc/aspeed_xdma.c | 2 +-
>   hw/rtc/aspeed_rtc.c   | 2 +-
>   hw/sd/aspeed_sdhci.c  | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)

\o/

Thanks for the help :)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] aspeed/{xdma,rtc,sdhci}: Fix endianness to DEVICE_LITTLE_ENDIAN

[Cédric Le Goater]

On 11/25/25 16:38, Philippe Mathieu-Daudé wrote:
> On 25/11/25 15:26, Cédric Le Goater wrote:
>> When the XDMA, RTC and SDHCI device models of the Aspeed SoCs were
>> first introduced, their MMIO regions inherited of a DEVICE_NATIVE_ENDIAN
>> endianness. It should be DEVICE_LITTLE_ENDIAN. Fix that.
>>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> ---
>>   hw/misc/aspeed_xdma.c | 2 +-
>>   hw/rtc/aspeed_rtc.c   | 2 +-
>>   hw/sd/aspeed_sdhci.c  | 2 +-
>>   3 files changed, 3 insertions(+), 3 deletions(-)
> 
> \o/
> 
> Thanks for the help :)

Only 379 left !

Cheers,

C.

Re: [PATCH] aspeed/{xdma,rtc,sdhci}: Fix endianness to DEVICE_LITTLE_ENDIAN

[Philippe Mathieu-Daudé]

On 25/11/25 15:26, Cédric Le Goater wrote:
> When the XDMA, RTC and SDHCI device models of the Aspeed SoCs were
> first introduced, their MMIO regions inherited of a DEVICE_NATIVE_ENDIAN
> endianness. It should be DEVICE_LITTLE_ENDIAN. Fix that.
> 
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   hw/misc/aspeed_xdma.c | 2 +-
>   hw/rtc/aspeed_rtc.c   | 2 +-
>   hw/sd/aspeed_sdhci.c  | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)

Queued, thanks.

Re: [PATCH] aspeed/{xdma, rtc, sdhci}: Fix endianness to DEVICE_LITTLE_ENDIAN

[Michael Tokarev]

On 11/25/25 17:26, Cédric Le Goater via wrote:
> When the XDMA, RTC and SDHCI device models of the Aspeed SoCs were
> first introduced, their MMIO regions inherited of a DEVICE_NATIVE_ENDIAN
> endianness. It should be DEVICE_LITTLE_ENDIAN. Fix that.

This looks like another bit for qemu-stable.  I'm picking it up
for 10.0 and 10.1 series.  Please let me know if I shouldn't.

Thanks,

/mjt

Re: [PATCH] aspeed/{xdma, rtc, sdhci}: Fix endianness to DEVICE_LITTLE_ENDIAN

[Cédric Le Goater]

On 11/26/25 07:48, Michael Tokarev wrote:
> On 11/25/25 17:26, Cédric Le Goater via wrote:
>> When the XDMA, RTC and SDHCI device models of the Aspeed SoCs were
>> first introduced, their MMIO regions inherited of a DEVICE_NATIVE_ENDIAN
>> endianness. It should be DEVICE_LITTLE_ENDIAN. Fix that.
> 
> This looks like another bit for qemu-stable.  I'm picking it up
> for 10.0 and 10.1 series.  Please let me know if I shouldn't.

You can. It shouldn't harm anyone.

Thanks,

C.