From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AA38C7115D for ; Mon, 23 Jun 2025 08:21:32 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uTcQS-0000XJ-L9; Mon, 23 Jun 2025 04:21:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uTcQA-0000QL-Bn for qemu-devel@nongnu.org; Mon, 23 Jun 2025 04:20:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uTcQ3-00086O-9H for qemu-devel@nongnu.org; Mon, 23 Jun 2025 04:20:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750666842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GBbPkcJ+cqTlKtkPkEOBLY6Eme/Qi2QlGOOm0lPBfy8=; b=YLdnT5A3lc6DrIyM4Vhi3DOcra9P42TovF1NxaB3igUZQf4NSXJBJrLKbwyLcmSoYMZ3tK ZWWj3w/Nc6TU2Uxn/fwnxLHZhplskz2AKVdPqF9CqmPddnQsIqChHlmISbLN6YnNBRgqjA LTtHVgnTJbmdIDYTkEgLEWU8+C/5oFU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-WNcFfqDuO_2R-umJ6Qm5VA-1; Mon, 23 Jun 2025 04:20:36 -0400 X-MC-Unique: WNcFfqDuO_2R-umJ6Qm5VA-1 X-Mimecast-MFC-AGG-ID: WNcFfqDuO_2R-umJ6Qm5VA_1750666830 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a3696a0d3aso1654576f8f.2 for ; Mon, 23 Jun 2025 01:20:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750666830; x=1751271630; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GBbPkcJ+cqTlKtkPkEOBLY6Eme/Qi2QlGOOm0lPBfy8=; b=EL6FaSCmcnR8iedeowpVpIxYx5Vm5fvSUNEiO2/DkFwBuZa7KlhAcHaPV/7wOzy5RC lNBf6FpeGzy7ZBEgF19qpkttsY9zeKP3fYtAwt82/MC2OQvcvnTh7o0+yW0Gx7mC4XfA S8eHvbSF38MPea5gmIqcQ1meSTrHtFNovbldgi68PXJ3FooBL2ILLyUtZ9LzNmXyrK0l lk+PW875iI+jsGiIZ7KbI8X+Bv8cskRZQU9UolmTA2hL6nSJgd4fTWgxDVPHK1k9TcWK l8KaekxFQo90cEwmKz0ub7xMo9LOCjfyYmNndrQP382+nW+gr7p4mSN5mV2snMulG/58 yHWQ== X-Forwarded-Encrypted: i=1; AJvYcCWzlOOpFnTApxl3WapKJGgGYjSDnXt1nKuEHMR6YxYwQYCxd6/lOxh1m8QjhmBexJeqXHSSyc7H2o3i@nongnu.org X-Gm-Message-State: AOJu0YywC3im3pp9LziS1pN19pw7ZVvUCjEAJtxxcNHg1ruPV0OA9lYD Zu/iQWUauIwOhBakxfqYif63Dd7uV8++sEZfFSR+9omWvo6jGt3wWbfevHEFdQas+faKLmxW0NI IlQ9ZlKFUxVGt9mbYOX2WnJ+Z56Im9JRtl4DNBOwd85Hq3tBiRsZ7MrV4 X-Gm-Gg: ASbGncuGxW/xgQ+lELiOqd0OAgNcHaviT3zsMlKdrBGUfSvgGlL0G0zRluVEPpzDkG2 xYwEJdPlf/r/QuFRLWVwK789N3HikvXRDAEqffUAQfwlVkivbBcyj2nWAfETBhiE4B6EbsujJvS ffn7bc3G8KdBhI+/BAKFcRfm2qfIShXuDkHNJAz4CIoTLk9uMiTPNreT9+/nhl0QXp780ukiEiS M5/4Vn0IeRb4G4c2xFJ9fWWy0YF++ROIvTLd3pM5KyhiREZS+zab6NL0MuWmuVNMi6wbSkK30z9 87VrrMMkTHAEzXfgkBih8Dn886YjrXrttAfQBavUnHdz5Hb8qgIUaxYDEYJTBQg= X-Received: by 2002:a05:6000:4605:b0:3a4:f6b7:8b07 with SMTP id ffacd0b85a97d-3a6d12e39famr8683851f8f.48.1750666830073; Mon, 23 Jun 2025 01:20:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/Uj5nWePqNYKo9LSNAcTJLy/FnRdV1bFqZ8no0/cHAlOiRtvPb7HGQmp5kR7f9BItTqveRw== X-Received: by 2002:a05:6000:4605:b0:3a4:f6b7:8b07 with SMTP id ffacd0b85a97d-3a6d12e39famr8683830f8f.48.1750666829696; Mon, 23 Jun 2025 01:20:29 -0700 (PDT) Received: from [192.168.0.7] (ltea-047-064-114-166.pools.arcor-ip.net. [47.64.114.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453647f29bdsm101598745e9.18.2025.06.23.01.20.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 01:20:29 -0700 (PDT) Message-ID: <5ce9667b-3e88-4882-9e70-f5511f9cbe07@redhat.com> Date: Mon, 23 Jun 2025 10:20:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 25/26] tests/functional: Add hvf_available() helper To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , Paolo Bonzini , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Phil Dennis-Jordan , =?UTF-8?Q?Alex_Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Roman Bolshakov , John Snow References: <20250620130709.31073-1-philmd@linaro.org> <20250620130709.31073-26-philmd@linaro.org> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250620130709.31073-26-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 20/06/2025 15.07, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > python/qemu/utils/__init__.py | 2 +- > python/qemu/utils/accel.py | 8 ++++++++ > tests/functional/qemu_test/testcase.py | 6 ++++-- > 3 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/python/qemu/utils/__init__.py b/python/qemu/utils/__init__.py > index 017cfdcda75..d2fe5db223c 100644 > --- a/python/qemu/utils/__init__.py > +++ b/python/qemu/utils/__init__.py > @@ -23,7 +23,7 @@ > from typing import Optional > > # pylint: disable=import-error > -from .accel import kvm_available, list_accel, tcg_available > +from .accel import hvf_available, kvm_available, list_accel, tcg_available > > > __all__ = ( > diff --git a/python/qemu/utils/accel.py b/python/qemu/utils/accel.py > index 386ff640ca8..376d1e30005 100644 > --- a/python/qemu/utils/accel.py > +++ b/python/qemu/utils/accel.py > @@ -82,3 +82,11 @@ def tcg_available(qemu_bin: str) -> bool: > @param qemu_bin (str): path to the QEMU binary > """ > return 'tcg' in list_accel(qemu_bin) > + > +def hvf_available(qemu_bin: str) -> bool: > + """ > + Check if HVF is available. > + > + @param qemu_bin (str): path to the QEMU binary > + """ > + return 'hvf' in list_accel(qemu_bin) > diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py > index 50c401b8c3c..2082c6fce43 100644 > --- a/tests/functional/qemu_test/testcase.py > +++ b/tests/functional/qemu_test/testcase.py > @@ -23,7 +23,7 @@ > import uuid > > from qemu.machine import QEMUMachine > -from qemu.utils import kvm_available, tcg_available > +from qemu.utils import hvf_available, kvm_available, tcg_available > > from .archive import archive_extract > from .asset import Asset > @@ -317,7 +317,9 @@ def require_accelerator(self, accelerator): > :type accelerator: str > """ > checker = {'tcg': tcg_available, > - 'kvm': kvm_available}.get(accelerator) > + 'kvm': kvm_available, > + 'hvf': hvf_available, > + }.get(accelerator) > if checker is None: > self.skipTest("Don't know how to check for the presence " > "of accelerator %s" % accelerator) Reviewed-by: Thomas Huth