From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, peterx@redhat.com,
davidkiarie4@gmail.com, jan.kiszka@web.de, bd.aviv@gmail.com,
alex.williamson@redhat.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 4/4] machine: remove iommu property
Date: Wed, 15 Jun 2016 00:03:40 +0200 [thread overview]
Message-ID: <5d0161ed-06ab-015d-f402-2a40d0efae8c@redhat.com> (raw)
In-Reply-To: <20160614183827.GW18662@thinpad.lan.raisama.net>
On 14/06/2016 20:38, Eduardo Habkost wrote:
> On Mon, Jun 13, 2016 at 05:37:00PM +0300, Marcel Apfelbaum wrote:
>> Since iommu devices can be created with '-device' there is
>> no need to keep iommu as machine and mch property.
>>
>> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
>
> On the one hand, the option is present since v2.2.0. On the other
> hand, it is present only in q35, and the property really doesn't
> belong to TYPE_MACHINE (so even if we decide to keep it for a few
> releases, property registration needs to be moved to
> pc_q35_machine_options().
>
> What kind of usage the existing code has, currently? Development
> and debugging only, or is there any chance somebody might be
> using it in production?
Definitely development and debugging only. Someone might be using it in
automated tests, but that's pretty much it.
Paolo
next prev parent reply other threads:[~2016-06-14 22:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 14:36 [Qemu-devel] [PATCH v3 0/4] enable iommu with -device Marcel Apfelbaum
2016-06-13 14:36 ` [Qemu-devel] [PATCH v3 1/4] hw/pci: delay bus_master_enable_region initialization Marcel Apfelbaum
2016-06-13 14:36 ` [Qemu-devel] [PATCH v3 2/4] q35: allow dynamic sysbus Marcel Apfelbaum
2016-06-13 14:36 ` [Qemu-devel] [PATCH v3 3/4] hw/iommu: enable iommu with -device Marcel Apfelbaum
2016-06-13 14:37 ` [Qemu-devel] [PATCH v3 4/4] machine: remove iommu property Marcel Apfelbaum
2016-06-14 18:38 ` Eduardo Habkost
2016-06-14 22:03 ` Paolo Bonzini [this message]
2016-06-17 7:30 ` Jan Kiszka
2016-06-13 20:51 ` [Qemu-devel] [PATCH v3 0/4] enable iommu with -device Michael S. Tsirkin
2016-06-14 7:03 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d0161ed-06ab-015d-f402-2a40d0efae8c@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=bd.aviv@gmail.com \
--cc=davidkiarie4@gmail.com \
--cc=ehabkost@redhat.com \
--cc=jan.kiszka@web.de \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).