From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCwR7-0005ug-FL for qemu-devel@nongnu.org; Tue, 14 Jun 2016 18:03:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCwR0-00061x-Ar for qemu-devel@nongnu.org; Tue, 14 Jun 2016 18:03:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCwR0-00061r-54 for qemu-devel@nongnu.org; Tue, 14 Jun 2016 18:03:46 -0400 References: <1465828620-12666-1-git-send-email-marcel@redhat.com> <1465828620-12666-5-git-send-email-marcel@redhat.com> <20160614183827.GW18662@thinpad.lan.raisama.net> From: Paolo Bonzini Message-ID: <5d0161ed-06ab-015d-f402-2a40d0efae8c@redhat.com> Date: Wed, 15 Jun 2016 00:03:40 +0200 MIME-Version: 1.0 In-Reply-To: <20160614183827.GW18662@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 4/4] machine: remove iommu property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , Marcel Apfelbaum Cc: qemu-devel@nongnu.org, mst@redhat.com, peterx@redhat.com, davidkiarie4@gmail.com, jan.kiszka@web.de, bd.aviv@gmail.com, alex.williamson@redhat.com, armbru@redhat.com On 14/06/2016 20:38, Eduardo Habkost wrote: > On Mon, Jun 13, 2016 at 05:37:00PM +0300, Marcel Apfelbaum wrote: >> Since iommu devices can be created with '-device' there is >> no need to keep iommu as machine and mch property. >> >> Signed-off-by: Marcel Apfelbaum > > On the one hand, the option is present since v2.2.0. On the other > hand, it is present only in q35, and the property really doesn't > belong to TYPE_MACHINE (so even if we decide to keep it for a few > releases, property registration needs to be moved to > pc_q35_machine_options(). > > What kind of usage the existing code has, currently? Development > and debugging only, or is there any chance somebody might be > using it in production? Definitely development and debugging only. Someone might be using it in automated tests, but that's pretty much it. Paolo