From: Max Reitz <mreitz@redhat.com>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>, kwolf@redhat.com
Cc: rjones@redhat.com, jcody@redhat.com, eblake@redhat.com,
armbru@redhat.com, berrange@redhat.com, kraxel@redhat.com,
pbonzini@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [v2 1/5] block/ssh: Add ssh_has_filename_options_conflict()
Date: Sat, 15 Oct 2016 23:28:58 +0200 [thread overview]
Message-ID: <5d104598-f768-95db-80a5-91028ce958c6@redhat.com> (raw)
In-Reply-To: <1476522280-23211-2-git-send-email-ashijeetacharya@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 563 bytes --]
On 15.10.2016 11:04, Ashijeet Acharya wrote:
> We have 5 options plus ("server") option which is added in the next
> patch that conflict with specifying a SSH filename. We need to iterate
> over all the options to check whether its key has an "server." prefix.
>
> This iteration will help us adding the new option "server" easily.
>
> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
> ---
> block/ssh.c | 27 +++++++++++++++++++++------
> 1 file changed, 21 insertions(+), 6 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 480 bytes --]
next prev parent reply other threads:[~2016-10-15 21:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 9:04 [Qemu-devel] [v2 0/5] Allow blockdev-add for SSH Ashijeet Acharya
2016-10-15 9:04 ` [Qemu-devel] [v2 1/5] block/ssh: Add ssh_has_filename_options_conflict() Ashijeet Acharya
2016-10-15 21:28 ` Max Reitz [this message]
2016-10-15 9:04 ` [Qemu-devel] [v2 2/5] block/ssh: Add InetSocketAddress and accept it Ashijeet Acharya
2016-10-15 22:30 ` Max Reitz
2016-10-16 8:53 ` Ashijeet Acharya
2016-10-16 9:10 ` Ashijeet Acharya
2016-10-17 11:27 ` Kevin Wolf
2016-10-17 12:33 ` Ashijeet Acharya
2016-10-17 12:57 ` Kevin Wolf
2016-10-17 15:44 ` Ashijeet Acharya
2016-10-17 15:53 ` Kevin Wolf
2016-10-17 15:56 ` Ashijeet Acharya
2016-10-17 15:59 ` Eric Blake
2016-10-17 16:08 ` Ashijeet Acharya
2016-10-15 9:04 ` [Qemu-devel] [v2 3/5] block/ssh: Use inet_connect_saddr() to establish socket connection Ashijeet Acharya
2016-10-15 22:34 ` Max Reitz
2016-10-15 9:04 ` [Qemu-devel] [v2 4/5] block/ssh: Use InetSocketAddress options Ashijeet Acharya
2016-10-15 22:37 ` Max Reitz
2016-10-15 9:04 ` [Qemu-devel] [v2 5/5] qapi: allow blockdev-add for ssh Ashijeet Acharya
2016-10-15 22:43 ` Max Reitz
2016-10-15 9:25 ` [Qemu-devel] [v2 0/5] Allow blockdev-add for SSH no-reply
2016-10-17 11:29 ` Kevin Wolf
2016-10-17 12:33 ` Ashijeet Acharya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d104598-f768-95db-80a5-91028ce958c6@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=ashijeetacharya@gmail.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).