From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Ashijeet Acharya <ashijeetacharya@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] build: Work around SIZE_MAX bug in OSX headers
Date: Mon, 10 Oct 2016 13:39:05 -0500 [thread overview]
Message-ID: <5d2c7e5c-4691-4f9e-bf18-911aa5349c3f@redhat.com> (raw)
In-Reply-To: <768804d4-1447-7189-5321-8fd1025d6a2d@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
On 10/10/2016 01:38 PM, Eric Blake wrote:
> On 10/10/2016 10:12 AM, Peter Maydell wrote:
>
>>> v2: rewrite into a configure check (not sure if directly adding a
>>> -D to QEMU_CFLAGS is the best, so advice welcome)
>>
>> Writing into config-host.mak would be preferable I think.
>>
>
> Okay, attempted in v4.
I can't type today. I just sent v3, not v4.
>
>>> I lack easy access to a Mac box, so this is untested as to whether
>>> it actually solves the issue...
>>
>> I ran a test with one of the cast workarounds locally removed,
>> and this patch does allow the %zu version to build OK on OSX.
>
> Thanks. But v3 leaves off Tested-by, because I still need to make sure
> my configure magic worked correctly :)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2016-10-10 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 14:38 [Qemu-devel] [PATCH v2] build: Work around SIZE_MAX bug in OSX headers Eric Blake
2016-10-10 15:12 ` Peter Maydell
2016-10-10 18:38 ` Eric Blake
2016-10-10 18:39 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d2c7e5c-4691-4f9e-bf18-911aa5349c3f@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=ashijeetacharya@gmail.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).