qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Cc: Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth"
Date: Tue, 23 Jun 2020 19:07:22 +0200	[thread overview]
Message-ID: <5d3c4773-5aa2-e80d-68c7-a94eac8a7422@redhat.com> (raw)
In-Reply-To: <3554a068-ba6f-0aa0-38b4-b6dca3069630@redhat.com>

On 23/06/2020 17.39, Philippe Mathieu-Daudé wrote:
> On 6/23/20 4:56 PM, Michael S. Tsirkin wrote:
>> This reverts commit 6d1da867e65f ("tests/migration: Reduce autoconverge initial bandwidth")
>> since that change makes unit tests much slower for all developers, while it's not
>> a robust way to fix migration tests. Migration tests need to find
>> a more robust way to discover a reasonable bandwidth without slowing
>> things down for everyone.
> 
> Please also mention we can do this since 1de8e4c4dcf which allow
> marked the s390x job as "unstable" and allow it to fail.
> 
> But if nobody is going to look at it, instead lets disable
> it until someone figure out the issue:
> 
> -- >8 --
> diff --git a/.travis.yml b/.travis.yml
> index 74158f741b..364e67b14b 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -507,6 +507,7 @@ jobs:
> 
>      - name: "[s390x] Clang (disable-tcg)"
>        arch: s390x
> +      if: false # Temporarily disabled due to issue testing migration
> (see commit 6d1da867e65).
>        dist: bionic
>        compiler: clang
>        addons:

Sorry, but that looks wrong. First, the disable-tcg test does not run
the qtests at all. So this is certainly the wrong location here. Second,
if just one of the qtests is failing, please only disable that single
failing qtest and not the whole test pipeline.

 Thanks,
  Thomas



  reply	other threads:[~2020-06-23 17:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23 14:56 [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth" Michael S. Tsirkin
2020-06-23 15:39 ` Philippe Mathieu-Daudé
2020-06-23 17:07   ` Thomas Huth [this message]
2020-06-23 17:35     ` Philippe Mathieu-Daudé
2020-06-23 20:59       ` Michael S. Tsirkin
2020-06-24  5:04       ` Thomas Huth
2020-06-24 10:21         ` Philippe Mathieu-Daudé
2020-06-24 16:26           ` Philippe Mathieu-Daudé
2020-06-25  5:35             ` Thomas Huth
2020-06-23 20:58   ` Michael S. Tsirkin
2020-06-24 15:53 ` Dr. David Alan Gilbert
2020-06-30 13:07 ` Michael S. Tsirkin
2020-06-30 13:20   ` Thomas Huth
2020-06-30 14:43     ` Michael S. Tsirkin
2020-06-30 14:44       ` Thomas Huth
2020-06-30 13:59   ` Dr. David Alan Gilbert
2020-06-30 14:43     ` Michael S. Tsirkin
2020-06-30 14:54       ` Dr. David Alan Gilbert
2020-06-30 14:55 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d3c4773-5aa2-e80d-68c7-a94eac8a7422@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).