From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
Laurent Vivier <lvivier@redhat.com>, Helge Deller <deller@gmx.de>,
Fabiano Rosas <farosas@suse.de>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [PATCH v6 1/2] tests/qtest/boot-serial-test: Correct HPPA machine name
Date: Thu, 2 Jan 2025 16:22:17 +0100 [thread overview]
Message-ID: <5d40b27c-1f86-4295-a1d4-9174866d785c@redhat.com> (raw)
In-Reply-To: <20250102100340.43014-2-philmd@linaro.org>
On 02/01/2025 11.03, Philippe Mathieu-Daudé wrote:
> Commit 7df6f751176 ("hw/hppa: Split out machine creation")
> renamed the 'hppa' machine as 'B160L', but forgot to update
> the boot serial test, which ended being skipped.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 7df6f751176 ("hw/hppa: Split out machine creation")
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> tests/qtest/boot-serial-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c
> index 3b92fa5d506..7759e8c9702 100644
> --- a/tests/qtest/boot-serial-test.c
> +++ b/tests/qtest/boot-serial-test.c
> @@ -185,7 +185,7 @@ static const testdef_t tests[] = {
> sizeof(kernel_plml605), kernel_plml605 },
> { "arm", "raspi2b", "", "TT", sizeof(bios_raspi2), 0, bios_raspi2 },
> /* For hppa, force bios to output to serial by disabling graphics. */
> - { "hppa", "hppa", "-vga none", "SeaBIOS wants SYSTEM HALT" },
> + { "hppa", "B160L", "-vga none", "SeaBIOS wants SYSTEM HALT" },
> { "aarch64", "virt", "-cpu max", "TT", sizeof(kernel_aarch64),
> kernel_aarch64 },
> { "arm", "microbit", "", "T", sizeof(kernel_nrf51), kernel_nrf51 },
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2025-01-02 15:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 10:03 [PATCH v6 0/2] tests: Add functional tests for HPPA machines Philippe Mathieu-Daudé
2025-01-02 10:03 ` [PATCH v6 1/2] tests/qtest/boot-serial-test: Correct HPPA machine name Philippe Mathieu-Daudé
2025-01-02 15:22 ` Thomas Huth [this message]
2025-01-02 10:03 ` [PATCH v6 2/2] tests: Add functional tests for HPPA machines Philippe Mathieu-Daudé
2025-01-02 14:54 ` [PATCH v6 0/2] " Richard Henderson
2025-01-09 12:26 ` Philippe Mathieu-Daudé
2025-01-09 13:42 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d40b27c-1f86-4295-a1d4-9174866d785c@redhat.com \
--to=thuth@redhat.com \
--cc=deller@gmx.de \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).