From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Corey Minyard" <cminyard@mvista.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [RFC PATCH-for-9.1 2/4] hw/i2c: Fix checkpatch line over 80 chars warnings
Date: Wed, 8 May 2024 10:52:42 +0200 [thread overview]
Message-ID: <5d41782b-5e10-4841-aa77-f2464bd930b0@redhat.com> (raw)
In-Reply-To: <20240408213339.83149-3-philmd@linaro.org>
On 08/04/2024 23.33, Philippe Mathieu-Daudé wrote:
> We are going to modify these lines, fix their style
> in order to avoid checkpatch.pl warnings:
>
> WARNING: line over 80 characters
I think the common sense is nowadays that it is OK to have lines with e.g.
82 characters when it looks better than having ugly wrapped lines otherwise.
That's why it's only a warning, and not an error.
So for me, for most hunks in this file, it seems like keeping the long lines
looks better than breaking them.
Thomas
next prev parent reply other threads:[~2024-05-08 8:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 21:33 [RFC PATCH-for-9.1 0/4] hw/i2c: Convert to spec v7 (inclusive) terminology Philippe Mathieu-Daudé
2024-04-08 21:33 ` [RFC PATCH-for-9.1 1/4] hw/i2c: Fix checkpatch block comment warnings Philippe Mathieu-Daudé
2024-04-08 21:33 ` [RFC PATCH-for-9.1 2/4] hw/i2c: Fix checkpatch line over 80 chars warnings Philippe Mathieu-Daudé
2024-05-08 8:52 ` Thomas Huth [this message]
2024-04-08 21:33 ` [RFC PATCH-for-9.1 3/4] hw/i2c: Convert to spec v7 terminology (automatically) Philippe Mathieu-Daudé
2024-04-09 8:58 ` Paolo Bonzini
2024-04-09 9:44 ` Philippe Mathieu-Daudé
2024-04-09 9:00 ` Wolfram Sang
2024-05-08 8:55 ` Thomas Huth
2024-04-08 21:33 ` [RFC PATCH-for-9.1 4/4] hw/i2c: Convert to spec v7 terminology (manually) Philippe Mathieu-Daudé
2024-05-16 1:48 ` [RFC PATCH-for-9.1 0/4] hw/i2c: Convert to spec v7 (inclusive) terminology Corey Minyard via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d41782b-5e10-4841-aa77-f2464bd930b0@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=cminyard@mvista.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).