From: Paolo Bonzini <pbonzini@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Artyom Tarasenko <atar4qemu@gmail.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Hervé Poussineau" <hpoussin@reactos.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 1/3] lsi53c895a: hide 53c895a registers in 53c810
Date: Mon, 20 May 2019 11:32:33 +0200 [thread overview]
Message-ID: <5d5e4293-788d-e799-342b-ea3ce8a0c244@redhat.com> (raw)
In-Reply-To: <643f0224-1230-33c8-8b4c-a5c688872b4e@ilande.co.uk>
On 17/05/19 16:12, Mark Cave-Ayland wrote:
>> Initially I implemented it exactly as you suggest, via mask. But then
>> I thought that memory_region_init_alias makes aliasing more obvious.
>> I don't have a strong opinion on this one though.
>>
>> @Paolo, what do you think?
> My general feeling is that memory region aliases are more aimed at mapping areas into
> different address spaces. In this particular case it seems to me that the memory
> region for both devices is still 256 bytes, but it's just that internally the address
> decoder ignores bit 7 on the 810.
It's the same for me; whatever makes the code simpler is good. RAM
regions need to use aliases in order to simulate ignored bits in the
decoder, so it's okay to use that for MMIO as well. On the other hand,
it's true that a simple "&" does the job just as well.
Paolo
next prev parent reply other threads:[~2019-05-20 9:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 21:02 [Qemu-devel] [PATCH v2 0/3] Improve 40p, make AIX 5.1 boot Artyom Tarasenko
2019-05-04 21:02 ` Artyom Tarasenko
2019-05-04 21:02 ` [Qemu-devel] [PATCH v2 1/3] lsi53c895a: hide 53c895a registers in 53c810 Artyom Tarasenko
2019-05-04 21:02 ` Artyom Tarasenko
2019-05-05 10:41 ` Mark Cave-Ayland
2019-05-05 10:41 ` Mark Cave-Ayland
2019-05-06 8:42 ` Artyom Tarasenko
2019-05-06 14:22 ` Mark Cave-Ayland
2019-05-07 15:03 ` Artyom Tarasenko
2019-05-17 14:12 ` Mark Cave-Ayland
2019-05-20 9:32 ` Paolo Bonzini [this message]
2019-05-04 21:02 ` [Qemu-devel] [PATCH 2/3] 40p and prep: implement PCI bus mastering Artyom Tarasenko
2019-05-04 21:02 ` Artyom Tarasenko
2019-05-04 21:02 ` [Qemu-devel] [PATCH v2 3/3] hw/isa/i82378.c: use 1900 as a base year Artyom Tarasenko
2019-05-04 21:02 ` Artyom Tarasenko
2019-05-05 10:46 ` Mark Cave-Ayland
2019-05-05 10:46 ` Mark Cave-Ayland
2019-05-05 15:19 ` Philippe Mathieu-Daudé
2019-05-05 15:19 ` Philippe Mathieu-Daudé
2019-05-06 8:44 ` Artyom Tarasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5e4293-788d-e799-342b-ea3ce8a0c244@redhat.com \
--to=pbonzini@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=fam@euphon.net \
--cc=hpoussin@reactos.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).