From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KaTjX-0005yQ-VR
	for qemu-devel@nongnu.org; Tue, 02 Sep 2008 07:07:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KaTjV-0005y9-C8
	for qemu-devel@nongnu.org; Tue, 02 Sep 2008 07:07:38 -0400
Received: from [199.232.76.173] (port=52416 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KaTjU-0005y2-Qd
	for qemu-devel@nongnu.org; Tue, 02 Sep 2008 07:07:37 -0400
Received: from rv-out-0708.google.com ([209.85.198.243]:30441)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@gmail.com>) id 1KaTjU-0003JA-Cs
	for qemu-devel@nongnu.org; Tue, 02 Sep 2008 07:07:36 -0400
Received: by rv-out-0708.google.com with SMTP id f25so1767769rvb.22
	for <qemu-devel@nongnu.org>; Tue, 02 Sep 2008 04:07:34 -0700 (PDT)
Message-ID: <5d6222a80809020407l68f7ab87i6d2520c57c7ddeb3@mail.gmail.com>
Date: Tue, 2 Sep 2008 08:07:34 -0300
From: "Glauber Costa" <glommer@gmail.com>
In-Reply-To: <48BCFBB1.4090109@qumranet.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1220303503-19413-1-git-send-email-glommer@redhat.com>
	<48BCFBB1.4090109@qumranet.com>
Subject: [Qemu-devel] Re: [PATCH] Fix up pxe boot
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@qumranet.com>
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, apevec@redhat.com, Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org, chrisw@sous-sol.org, Eduardo Habkost <ehabkost@redhat.com>

On Tue, Sep 2, 2008 at 5:39 AM, Avi Kivity <avi@qumranet.com> wrote:
> Glauber Costa wrote:
>>
>> diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
>> index 0b5fdc0..433aa3f 100644
>> --- a/target-i386/op_helper.c
>> +++ b/target-i386/op_helper.c
>> @@ -600,7 +600,7 @@ do {\
>>  #define PUSHL(ssp, sp, sp_mask, val)\
>>  {\
>>     sp -= 4;\
>> -    stl_kernel((ssp) + (sp & (sp_mask)), (val));\
>> +    stl_kernel((uint32_t)((ssp) + (sp & (sp_mask))), (uint32_t)(val));\
>>  }
>>
>
> Surly it is better to push this into the underlying virtual->physical
> translation functions, so it applies everywhere?
>
> btw, the cast is wrong for x86-64, so it must be qualified for 32-bit
> operating modes.
The tests were all done with x86_64. This is a PUSHL macro, so it's
32-bit anyway.
A x86_64-only PUSHQ seems to do the right thing.

>
> --
> error compiling committee.c: too many arguments to function
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Glauber Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."