From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KeE61-0001QY-WF
	for qemu-devel@nongnu.org; Fri, 12 Sep 2008 15:14:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KeE60-0001Ml-Ak
	for qemu-devel@nongnu.org; Fri, 12 Sep 2008 15:14:21 -0400
Received: from [199.232.76.173] (port=36503 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KeE60-0001MW-7Z
	for qemu-devel@nongnu.org; Fri, 12 Sep 2008 15:14:20 -0400
Received: from rv-out-0708.google.com ([209.85.198.247]:2888)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@gmail.com>) id 1KeE60-0000rl-Od
	for qemu-devel@nongnu.org; Fri, 12 Sep 2008 15:14:20 -0400
Received: by rv-out-0708.google.com with SMTP id f25so912283rvb.22
	for <qemu-devel@nongnu.org>; Fri, 12 Sep 2008 12:14:17 -0700 (PDT)
Message-ID: <5d6222a80809121214w40153f5byf06884a2ae27c4d8@mail.gmail.com>
Date: Fri, 12 Sep 2008 16:14:17 -0300
From: "Glauber Costa" <glommer@gmail.com>
Subject: Re: [Qemu-devel] [PATCH/RFC] provide --accel option
In-Reply-To: <f43fc5580809121207u6a0b1008k178c7e42ff9f972@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1221245233-26152-1-git-send-email-glommer@redhat.com>
	<f43fc5580809121207u6a0b1008k178c7e42ff9f972@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Fri, Sep 12, 2008 at 4:07 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
> On 9/12/08, Glauber Costa <glommer@redhat.com> wrote:
>> The --accel option will provide us the ability of defining which
>>  accelerator to pick at run time. It has the advantage of not using
>>  the not-well-accepted constructor directives, and also, of stabilishing
>>  a way to define priorities among accelerators.
>>
>>  The ones registered first, are tried first.
>
>>  +            case QEMU_OPTION_accel:
>>  +                {
>>  +                    int i;
>>  +                    for (i = 0; i < sizeof(available_accels)/sizeof(void *); i++) {
>
> ARRAY_SIZE(available_accels)?
agreed.

>>  +                        if (!strcasecmp(optarg, available_accels[i]->name))
>>  +                            register_qemu_accel(available_accels[i]);
>>  +                    }
>>  +                }
>>  +                break;
>
>
>



-- 
Glauber Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."