From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqDWI-0003dA-FP for qemu-devel@nongnu.org; Wed, 15 Oct 2008 17:03:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqDWH-0003cb-7K for qemu-devel@nongnu.org; Wed, 15 Oct 2008 17:03:02 -0400 Received: from [199.232.76.173] (port=56531 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqDWG-0003cU-Uz for qemu-devel@nongnu.org; Wed, 15 Oct 2008 17:03:00 -0400 Received: from mail-gx0-f19.google.com ([209.85.217.19]:34642) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KqDWG-0004sb-Mh for qemu-devel@nongnu.org; Wed, 15 Oct 2008 17:03:00 -0400 Received: by gxk12 with SMTP id 12so7224632gxk.10 for ; Wed, 15 Oct 2008 14:03:00 -0700 (PDT) Message-ID: <5d6222a80810151402y3c3f31a6y3ea5d35806a81035@mail.gmail.com> Date: Wed, 15 Oct 2008 19:02:59 -0200 From: "Glauber Costa" Subject: Re: [Qemu-devel] Re: [PATCH 08/21] move disabling code to kqemu.c instead of vl.c In-Reply-To: <48F65345.1070404@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1224107718-19128-1-git-send-email-glommer@redhat.com> <1224107718-19128-9-git-send-email-glommer@redhat.com> <48F65345.1070404@us.ibm.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: jan.kiszka@siemens.com, Glauber Costa , jes@sgi.com, avi@qumranet.com, Glauber Costa , dmitry.baryshkov@siemens.com On Wed, Oct 15, 2008 at 6:32 PM, Anthony Liguori wrote: > Glauber Costa wrote: >> >> From: Glauber Costa >> >> kqemu is not smp. So instead of testing in vl.c, do the test in kqemu.c, >> and just refuse to start if smp_cpus > 1. >> > > Maybe the start accelerator should be passed the number of cpus instead of > relying on an extern variable? That's actually a good idea. > > Regards, > > Anthony Liguori > > > > -- Glauber Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act."