From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KuT4N-0008AP-6E
	for qemu-devel@nongnu.org; Mon, 27 Oct 2008 10:27:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KuT4M-00089E-6E
	for qemu-devel@nongnu.org; Mon, 27 Oct 2008 10:27:46 -0400
Received: from [199.232.76.173] (port=59255 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KuT4M-000894-3c
	for qemu-devel@nongnu.org; Mon, 27 Oct 2008 10:27:46 -0400
Received: from qb-out-1314.google.com ([72.14.204.172]:45650)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@gmail.com>) id 1KuT4M-0001Td-0i
	for qemu-devel@nongnu.org; Mon, 27 Oct 2008 10:27:46 -0400
Received: by qb-out-1314.google.com with SMTP id e19so1726535qba.8
	for <qemu-devel@nongnu.org>; Mon, 27 Oct 2008 07:27:43 -0700 (PDT)
Message-ID: <5d6222a80810270727l3a213a22yba93abb2a873a103@mail.gmail.com>
Date: Mon, 27 Oct 2008 12:27:43 -0200
From: "Glauber Costa" <glommer@gmail.com>
Subject: Re: [Qemu-devel] Preliminary patch to implement ehci
In-Reply-To: <4905C997.5060801@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1KqsdV-0000r9-5B@monty-python.gnu.org>
	<11d301c93090$7e06d290$7a1477b0$@com>
	<010f01c93810$47ccb500$d7661f00$@com> <4905C997.5060801@codemonkey.ws>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Mon, Oct 27, 2008 at 12:00 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Mark Burkley wrote:
>>
>> Hi folks,
>>
>> Just checking, did anyone get a chance to look at this?
>>
>> Any suggestions for next steps?  Should I post a patch against trunk?
>>
>
> Submitting the patch against 0.9.1 is a non-starter.  0.9.1 is at least a
> year old and the USB code has been majorly refactored.  If you want people
> to review it, it has to be against trunk.
>
> Also make sure that you include a [PATCH] in your subject.  Otherwise, it's
> easily missed on the list.
The chances of anyone reviewing a patch that big is also very small.
So please, split it in minor, self-contained patches so it make it
easier for reviewers.

>
> Regards,
>
> Anthony Liguori
>
>> Thanks,
>>
>> Mark
>>
>
>
>
>



-- 
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."