From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KxNJA-0004b4-Ce
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 09:55:04 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KxNJ9-0004aX-UC
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 09:55:04 -0500
Received: from [199.232.76.173] (port=40613 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KxNJ9-0004aQ-N9
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 09:55:03 -0500
Received: from yx-out-1718.google.com ([74.125.44.155]:25377)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@gmail.com>) id 1KxNJ9-00037E-AU
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 09:55:03 -0500
Received: by yx-out-1718.google.com with SMTP id 3so1085817yxi.82
	for <qemu-devel@nongnu.org>; Tue, 04 Nov 2008 06:55:02 -0800 (PST)
Message-ID: <5d6222a80811040655u107e242cs6f1e7aaf33f2e6dc@mail.gmail.com>
Date: Tue, 4 Nov 2008 12:55:01 -0200
From: "Glauber Costa" <glommer@gmail.com>
Subject: Re: [Qemu-devel] vga optmization
In-Reply-To: <49106171.5080209@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20081103173111.GC30410@poweredge.glommer>
	<fb249edb0811040131r2991e2bwc0ec416162dfcee5@mail.gmail.com>
	<491034BC.2050806@eu.citrix.com> <49106171.5080209@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com

On Tue, Nov 4, 2008 at 12:51 PM, Avi Kivity <avi@redhat.com> wrote:
> Stefano Stabellini wrote:
>>
>> Why don't you make qemu_physical_sync_dirty_bitmap take also and end
>> address, and you merge the two bitmaps in this address range in this
>> function, so you don't have to change cpu_physical_memory_get_dirty at
>> all?
>>
>> I am saying to do something like:
>>
>> void qemu_physical_sync_dirty_bitmap(ram_addr_t start_addr, ram_addr_t
>> end_addr)
>> {
>>        /* sync and merge the two bitmaps between start_addr and end_addr
>> */
>> }
>>
>> then leave cpu_physical_memory_get_dirty untouched.
>> I would prefer this approch, it also leaves more space to other
>> optimizations.
>>
>
> That's how current kvm userspace works.  It's also more correct, since the
> kvm bitmap feeds both the vga dirty bits and the live migration dirty bits.

My reason to do this way, was to be lazy about updating the dirty bitmap.
But if the common case is to check for all pages in the region, then
it won't matter much.

>
> --
> error compiling committee.c: too many arguments to function
>
>
>
>



-- 
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."