From: "Glauber Costa" <glommer@gmail.com>
To: qemu-devel@nongnu.org
Cc: Glauber Costa <glommer@redhat.com>,
avi@redhat.com, kvm@vger.kernel.org,
stefano.stabellini@eu.citrix.com
Subject: Re: [Qemu-devel] Re: [PATCH] hook cpu running at a higher level.
Date: Tue, 30 Dec 2008 09:35:06 -0200 [thread overview]
Message-ID: <5d6222a80812300335kacdf330pfe4a51e59e0e203e@mail.gmail.com> (raw)
In-Reply-To: <18777.63215.125693.799799@mariner.uk.xensource.com>
On Tue, Dec 30, 2008 at 8:24 AM, Ian Jackson > The Xen qemu process
runs only in one thread which is fine because it
> doesn't need to be involved with actual processor execution. In
> theory parallel execution (in different threads and thus on different
> physical cpus) of IO emulations requested by different guest vcpus
> might make some small performance difference but I doubt it would be
> worth our while. So I think the Xen setup will still from qemu's
> point of view look like a single vcpu no matter how many vcpus the
> guest aactually has.
Is it one vcpu or various in lockstep ? If you have only one vcpu,
your main loop can be even simpler than qemu's, which holds them all
in a for loop.
> The way we have approached these problems in the Xen tree is to supply
> an alternative implementation of (say) main_loop and arrange for the
> standard one not to be compiled. Is it the intent to make kvm a
> run-time selectable option ? It seems to me that that given that we
> already have different qemu builds for all of the various target
> (guest) cpu architectures, it might be simpler to continue that
> approach. With a bit of judicious movement of code into appropriate
> files, this will avoid the need for ifs and ifdefs.
>
I believe the idea here is to bring up something close to the accel
patches (this one, plus the ones for memory_rw and registered I
already posted). So you would not see this, but simply
"cpu_main_loop()", that would call into the right thing, no matter
what it is. This allow for both runtime and compile time selection of
what you're running.
--
Glauber Costa.
"Free as in Freedom"
http://glommer.net
"The less confident you are, the more serious you have to act."
next prev parent reply other threads:[~2008-12-30 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 18:29 [Qemu-devel] [PATCH] hook cpu running at a higher level Glauber Costa
2008-12-30 10:24 ` [Qemu-devel] " Ian Jackson
2008-12-30 10:44 ` Avi Kivity
2008-12-30 13:45 ` Ian Jackson
2008-12-30 11:35 ` Glauber Costa [this message]
2008-12-30 17:25 ` Ian Jackson
2008-12-30 13:54 ` Avi Kivity
2008-12-30 14:44 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d6222a80812300335kacdf330pfe4a51e59e0e203e@mail.gmail.com \
--to=glommer@gmail.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).