From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LUNZS-00033U-Q5 for qemu-devel@nongnu.org; Tue, 03 Feb 2009 10:52:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LUNZS-00033D-D0 for qemu-devel@nongnu.org; Tue, 03 Feb 2009 10:52:18 -0500 Received: from [199.232.76.173] (port=35296 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUNZR-00033A-CM for qemu-devel@nongnu.org; Tue, 03 Feb 2009 10:52:17 -0500 Received: from mail-qy0-f20.google.com ([209.85.221.20]:46394) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LUNZR-00010B-31 for qemu-devel@nongnu.org; Tue, 03 Feb 2009 10:52:17 -0500 Received: by qyk13 with SMTP id 13so3959331qyk.10 for ; Tue, 03 Feb 2009 07:52:15 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <0787F5E2-2C38-43C2-A9CB-97BA8A36F212@suse.de> References: <1233673454-14526-1-git-send-email-glommer@redhat.com> <0787F5E2-2C38-43C2-A9CB-97BA8A36F212@suse.de> Date: Tue, 3 Feb 2009 13:52:15 -0200 Message-ID: <5d6222a80902030752h3841fdbdsff9a78f88d53a579@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH] don't expose lm bit if kernel is not 64-bit capable. From: Glauber Costa Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Glauber Costa On Tue, Feb 3, 2009 at 1:44 PM, Alexander Graf wrote: > This doesn't really compile on win32, does it? This is kvm code, and as we don't have kvm for win32 hosts, possibly does not matter. > > Why not check for sizeof(long) == 4? That way you'd know that you're running > 32-bit code which can only handle 32-bit guests anyway, right? And if you're > running 64-bit userspace code, you know that the kernel is 64-bit aware. How about qemu/kvm compiled in a 32-bit environment, thus, sizeof long == 4, running in a x86_64 capable kernel? -- Glauber Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act."