From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LmeKz-0005Ou-W6
	for qemu-devel@nongnu.org; Wed, 25 Mar 2009 21:24:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LmeKu-0005Lp-GM
	for qemu-devel@nongnu.org; Wed, 25 Mar 2009 21:24:52 -0400
Received: from [199.232.76.173] (port=40401 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LmeKu-0005Lm-3k
	for qemu-devel@nongnu.org; Wed, 25 Mar 2009 21:24:48 -0400
Received: from rv-out-0708.google.com ([209.85.198.244]:43330)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@gmail.com>) id 1LmeKs-0000L2-Ta
	for qemu-devel@nongnu.org; Wed, 25 Mar 2009 21:24:47 -0400
Received: by rv-out-0708.google.com with SMTP id l33so281867rvb.22
	for <qemu-devel@nongnu.org>; Wed, 25 Mar 2009 18:24:43 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090325225438.990466524@amt.cnet>
References: <20090325224714.853788328@amt.cnet>
	<20090325225438.990466524@amt.cnet>
Date: Wed, 25 Mar 2009 22:24:43 -0300
Message-ID: <5d6222a80903251824y54efea5fk21f145648c83c081@mail.gmail.com>
Subject: Re: [Qemu-devel] [patch 04/10] qemu: introduce main_loop_break
From: Glauber Costa <glommer@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>

> +static void setup_iothread_fd(void)
> +{
> + =C2=A0 =C2=A0int fds[2];
> +
> + =C2=A0 =C2=A0if (pipe(fds) =3D=3D -1) {
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0fprintf(stderr, "failed to create iothread p=
ipe");
qemu_log() ?

in general, looks good



--=20
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."