From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LnQ1O-0001UM-JR
	for qemu-devel@nongnu.org; Sat, 28 Mar 2009 00:19:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LnQ1N-0001TL-VE
	for qemu-devel@nongnu.org; Sat, 28 Mar 2009 00:19:50 -0400
Received: from [199.232.76.173] (port=32852 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LnQ1N-0001T8-Or
	for qemu-devel@nongnu.org; Sat, 28 Mar 2009 00:19:49 -0400
Received: from qw-out-1920.google.com ([74.125.92.147]:19481)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@gmail.com>) id 1LnQ1N-00041W-HV
	for qemu-devel@nongnu.org; Sat, 28 Mar 2009 00:19:49 -0400
Received: by qw-out-1920.google.com with SMTP id 5so877520qwf.4
	for <qemu-devel@nongnu.org>; Fri, 27 Mar 2009 21:19:49 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <49CD8458.3080405@gmx.net>
References: <1238197702-2765-1-git-send-email-glommer@redhat.com>
	<49CD8458.3080405@gmx.net>
Date: Sat, 28 Mar 2009 01:19:48 -0300
Message-ID: <5d6222a80903272119y46f9855agac6b9035af796184@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] get roms more room.
From: Glauber Costa <glommer@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com

>
> I really like the patch, but I have one questions I can't answer because
> I'm not familiar enough with the Qemu and Bochs BIOS codebase. You can
> find it as inline comment.
>
> Since the patch seems to do what I want, it is
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
>
> If a Signed-off-by line is preferred, I can send that instead.
>
>> ---
>> =C2=A0hw/pc.c | =C2=A0 27 +++++++++++++++++----------
>> =C2=A01 files changed, 17 insertions(+), 10 deletions(-)
>>
>> + =C2=A0 =C2=A0 /* Round up vga bios size to the next 2k boundary */
>> + =C2=A0 =C2=A0 vga_bios_size =3D (vga_bios_size + 2047) & ~2047;
>>
>
> If vga_bios_size ever shrinks below 30k, the option ROMs will start
> below 0xc8000 and the Bochs BIOS won't find them. Is that right?
>

Hummm, humm.... /me thinks....

You're actually right. Although it won't happen if our current codebase, it=
's
a very valid concern. I will send an updated patch soon, hopefully 100 % re=
ady
for inclusion.

Good catch!

--=20
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."