From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lx4P2-0004n1-1y for qemu-devel@nongnu.org; Thu, 23 Apr 2009 15:16:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lx4Ox-0004hr-I4 for qemu-devel@nongnu.org; Thu, 23 Apr 2009 15:16:07 -0400 Received: from [199.232.76.173] (port=47654 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lx4Ox-0004hb-CE for qemu-devel@nongnu.org; Thu, 23 Apr 2009 15:16:03 -0400 Received: from mail-qy0-f111.google.com ([209.85.221.111]:63182) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lx4Ox-0005Xo-1m for qemu-devel@nongnu.org; Thu, 23 Apr 2009 15:16:03 -0400 Received: by qyk9 with SMTP id 9so1427769qyk.4 for ; Thu, 23 Apr 2009 12:16:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20090423191040.GI3795@csclub.uwaterloo.ca> References: <20090423185308.GH3795@csclub.uwaterloo.ca> <20090423191040.GI3795@csclub.uwaterloo.ca> Date: Thu, 23 Apr 2009 16:15:59 -0300 Message-ID: <5d6222a80904231215p62c6594asc50230b252e892aa@mail.gmail.com> Subject: Re: [Qemu-devel] [7234] Use a more natural order From: Glauber Costa Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lennart Sorensen Cc: Blue Swirl , qemu-devel@nongnu.org On Thu, Apr 23, 2009 at 4:10 PM, Lennart Sorensen wrote: > On Thu, Apr 23, 2009 at 10:01:43PM +0300, Blue Swirl wrote: >> True, but it's not the style that is used here. You are of course free >> to argue for using this version and even submit patches. > > I didn't check if it is covered by the codestyle or not for qemu. > > If your patch comment had said "Fix to follow code style" rather than > "make natural order" I wouldn't have said anything. =C2=A0Natural order i= n > this case is a bad reason for the change. =C2=A0Following code style is a > good reason (even if the code style may then be questionable). > > If the code style doesn't cover it at all, I would say the change is > horrible and shouldn't be done at all. =C2=A0The change even caused a com= pile > failure briefly (and hence breaks git bisect) by being commited completel= y > untested I suspect. =C2=A0If it didn't cause a compile failure it at leas= t > should have caused a serious warning. Note that this could be avoided by not commiting the code in the first plac= e, but rather, sending it to the mailing list. Everybody should be sending cod= e to the mailing list, even maintainers. Anthony is already doing that, and it greatly reduces the probability of ge= tting a broken bisect for broken patches. --=20 Glauber Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act."